From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager] api: priv-api: admin-cli: use new logger builder
Date: Fri, 11 Apr 2025 13:39:06 +0200 [thread overview]
Message-ID: <vv7zaxr5u2ey7jigz2wlqrrfmuxa3mhskn6t5jpobjuojdmmmf@jukdowxbkkfy> (raw)
In-Reply-To: <20250411113247.230001-1-l.wagner@proxmox.com>
On 11.04.2025 13:32, Lukas Wagner wrote:
>Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
>---
>
>Notes:
> The Logger::tasklog_pbs is actually not specific to PBS but should be
> used for anything that uses WorkerTasks with a LogContext, as far as I
> can tell. We might want to rename it at some point.
Maybe we could put the first sentence here inside the commit message?
Otherwise LGTM!
Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> [snip]
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-04-11 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 11:32 Lukas Wagner
2025-04-11 11:39 ` Gabriel Goller [this message]
2025-04-11 12:12 ` [pdm-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vv7zaxr5u2ey7jigz2wlqrrfmuxa3mhskn6t5jpobjuojdmmmf@jukdowxbkkfy \
--to=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal