[pbs-devel] applied: [PATCH proxmox] router: sort cli properties in usage output

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Fri, Aug 09, 2024 at 10:25:25AM GMT, Dominik Csapak wrote:
> If we don't do this, then properties from a serde flattened struct will
> be positioned at the end of the list, rather than properly sorted with
> the other properties.
> 
> Since the tests also feature non-sorted properties, we have to adapt
> them too.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> i wanted to add tests for the serde flattened structs, but the test
> don't use the api macro, nor serde, so i was not sure how i could
> replicate that. If somebody has an idea for that, please tell, then
> I'll send a v2 or follow up

Those are just `AllOfSchemas` , you'd just have to make 2
`ObjectSchemas` and put them into an `AllOfSchema`.

I do wonder, though, whether we want some way to declare "groups" for
the documentation.
Using a flattened structs might sometimes work, but probably not all the
time. With this applied, flattened structs won't make a difference. But
given that the visible portion of the struct in code doesn't represent
the way it would be grouped anyway, we'd need a separate solution to
declare groups anyway.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel