From: Gabriel Goller <g.goller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: datastore: add missing log context for prune
Date: Tue, 28 Jan 2025 11:21:36 +0100 [thread overview]
Message-ID: <ulr6cbkyymdvnl2nxwaprl35xowo3ngyb4ldjmwpqhcrmlnptk@o3pcn343rpyd> (raw)
In-Reply-To: <20250127133826.356618-1-c.ebner@proxmox.com>
On 27.01.2025 14:38, Christian Ebner wrote:
>Adds the missing log context for cases were a prune is not executed
>as dedicated tokio task.
>
>Commit 432de66a ("api: make prune-group a real workertask") moved the
>prune group logic into it's own tokio task conditionally.
>
>However, the log context was missing for cases where no dedicated
>task/thread is started, leading to the worker task state being
>unknown after finish, as no logs are written to the worker task log
>file.
I had a feeling the "task-less" prune job would come back to haunt us,
and sure enough, here we are :(.
Fix looks good though, let's hope we can remove this in the next release
anyway.
Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-01-28 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 13:38 Christian Ebner
2025-01-28 10:21 ` Gabriel Goller [this message]
2025-01-28 12:09 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ulr6cbkyymdvnl2nxwaprl35xowo3ngyb4ldjmwpqhcrmlnptk@o3pcn343rpyd \
--to=g.goller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.