From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH promxox-mail-forward] fix logging by switching to proxmox-log
Date: Thu, 12 Jun 2025 17:16:26 +0200 [thread overview]
Message-ID: <tiyj4cvuftnivxten7lazqnuj2whwujnqce7tv3vziy33ekh6p@cs5zhodtxf6z> (raw)
In-Reply-To: <20250612123443.331965-1-l.wagner@proxmox.com>
Printing anyhow errors with "{:#}" would be nice, so that the whole
context is visible as well.
Otherwise LGTM!
Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-12 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 12:34 Lukas Wagner
2025-06-12 15:16 ` Gabriel Goller [this message]
2025-06-13 7:46 ` Lukas Wagner
2025-06-13 7:56 ` [pve-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tiyj4cvuftnivxten7lazqnuj2whwujnqce7tv3vziy33ekh6p@cs5zhodtxf6z \
--to=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.