[pbs-devel] [PATCH] textareafield: add emptyText message to show markdown is possible

[pbs-devel] [PATCH] textareafield: add emptyText message to show markdown is possible

[Gabriel Goller]

Just like in our `Notes` fields show a emptyText message that explains
that markdown can be used.

Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/form/TextAreaField.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/form/TextAreaField.js b/src/form/TextAreaField.js
index 267b40c87d74..ed6015a9ec51 100644
--- a/src/form/TextAreaField.js
+++ b/src/form/TextAreaField.js
@@ -10,6 +10,7 @@ Ext.define('Proxmox.form.field.Base64TextArea', {
         width: 600,
         height: 400,
         scrollable: 'y',
+        emptyText: 'You can use Markdown for richt text formatting.',
     },
 
     setValue: function(value) {
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH] textareafield: add emptyText message to show markdown is possible

[Lukas Wagner]

On  2024-11-27 11:27, Gabriel Goller wrote:
> Just like in our `Notes` fields show a emptyText message that explains
> that markdown can be used.
> 
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  src/form/TextAreaField.js | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/form/TextAreaField.js b/src/form/TextAreaField.js
> index 267b40c87d74..ed6015a9ec51 100644
> --- a/src/form/TextAreaField.js
> +++ b/src/form/TextAreaField.js
> @@ -10,6 +10,7 @@ Ext.define('Proxmox.form.field.Base64TextArea', {
>          width: 600,
>          height: 400,
>          scrollable: 'y',
> +        emptyText: 'You can use Markdown for richt text formatting.',

This should use gettext :)
Also there is a typo in 'rich' :D

-- 
- Lukas


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH] textareafield: add emptyText message to show markdown is possible

[Gabriel Goller]

On 27.11.2024 11:29, Lukas Wagner wrote:
>On  2024-11-27 11:27, Gabriel Goller wrote:
>> Just like in our `Notes` fields show a emptyText message that explains
>> that markdown can be used.
>>
>> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>>  src/form/TextAreaField.js | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/form/TextAreaField.js b/src/form/TextAreaField.js
>> index 267b40c87d74..ed6015a9ec51 100644
>> --- a/src/form/TextAreaField.js
>> +++ b/src/form/TextAreaField.js
>> @@ -10,6 +10,7 @@ Ext.define('Proxmox.form.field.Base64TextArea', {
>>          width: 600,
>>          height: 400,
>>          scrollable: 'y',
>> +        emptyText: 'You can use Markdown for richt text formatting.',
>
>This should use gettext :)
>Also there is a typo in 'rich' :D

Ack, thanks for the review!
v2 is out!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel