From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH] textareafield: add emptyText message to show markdown is possible
Date: Wed, 27 Nov 2024 12:50:58 +0100 [thread overview]
Message-ID: <tfagihoddbybnryxafsisgsz5o2iaqc7ity3wa7d7yehhoh2dg@csrwmiczir7e> (raw)
In-Reply-To: <123dbdc2-192c-4565-af00-927a86c1ffd9@proxmox.com>
On 27.11.2024 11:29, Lukas Wagner wrote:
>On 2024-11-27 11:27, Gabriel Goller wrote:
>> Just like in our `Notes` fields show a emptyText message that explains
>> that markdown can be used.
>>
>> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> src/form/TextAreaField.js | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/form/TextAreaField.js b/src/form/TextAreaField.js
>> index 267b40c87d74..ed6015a9ec51 100644
>> --- a/src/form/TextAreaField.js
>> +++ b/src/form/TextAreaField.js
>> @@ -10,6 +10,7 @@ Ext.define('Proxmox.form.field.Base64TextArea', {
>> width: 600,
>> height: 400,
>> scrollable: 'y',
>> + emptyText: 'You can use Markdown for richt text formatting.',
>
>This should use gettext :)
>Also there is a typo in 'rich' :D
Ack, thanks for the review!
v2 is out!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-27 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 10:27 Gabriel Goller
2024-11-27 10:29 ` Lukas Wagner
2024-11-27 11:50 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tfagihoddbybnryxafsisgsz5o2iaqc7ity3wa7d7yehhoh2dg@csrwmiczir7e \
--to=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.