Re: [pdm-devel] [RFC datacenter-manager 00/13] backend implementation for view filters

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

Code-wise LGTM - nits could be addressed later.
Whether this is the way we want it needs to be decided I guess. Not sure
splitting by include/exclude this way is ideal, but I don't have better
ideas for the moment, although it may be interesting to add the ability
to use globs there at some point, then having both includes and excludes
makes *some* sense (but wouldn't allow for something like, "include all
'x*' except 'xy*' but do still include 'xyz*'" – that would need
orders/priorities.

On Wed, Oct 29, 2025 at 03:48:49PM +0100, Lukas Wagner wrote:
> Key aspects:
>   - new config file at /etc/proxmox-datacenter-manager/views/filters.cfg
>     (subject to change, depending on where the view templates are stored)
>   - ViewFilterConfig as a filter defintion type,has
>      - {include,exclude}-{remote,resource-id,resource-type,resource-pool,tag}
> 
>   - Filter implementation & big suite of unit tests
>     - excludes are processed after includes
>     - if no include rules are defined, all resources but those which were
>       excluded are matched
>     - if no rules are defined in a filter, everything is matched
> 
>   - Added the 'view-filter' parameter to a couple of API endpoints
>     - /resources/list
>     - /resources/status
>     - /resources/subscription
>     - /resources/top-entities
>     - /remote-tasks/list
>     - /remote-tasks/statistis
> 
>   - ACL checks are done on /view/{view-filter-id} for now, replace
>     any other permission check in the handler iff the view-filter paramter
>     is set
> 
> Left to do:
>   - CRUD for filter definition
>   - Decide on how exactly they will work together with the view templates
>      -> most likely a new config type 
>      
>      View {
>        filter: String,
>        template: String,
>      }
>   - UI for filter rules
> 
> 
> proxmox-datacenter-manager:
> 
> Lukas Wagner (13):
>   fake remote: add missing parameter for cluster_metrics_export function
>   pdm-api-types: views: add ViewFilterConfig type
>   pdm-config: views: add support for view-filters
>   acl: add '/view' and '/view/{view-id}' as allowed ACL paths
>   views: add implementation for view filters
>   views: add tests for view filter implementation
>   api: resources: list: add support for view-filter parameter
>   api: resources: top entities: add support for view-filter parameter
>   api: resources: status: add support for view-filter parameter
>   api: subscription status: add support for view-filter parameter
>   api: remote-tasks: add support for view-filter parameter
>   pdm-client: resource list: add view-filter parameter
>   pdm-client: top entities: add view-filter parameter
> 
>  cli/client/src/resources.rs                  |   2 +-
>  lib/pdm-api-types/src/lib.rs                 |   8 +
>  lib/pdm-api-types/src/views.rs               | 147 ++++++
>  lib/pdm-client/src/lib.rs                    |  19 +-
>  lib/pdm-config/src/lib.rs                    |   2 +-
>  lib/pdm-config/src/views.rs                  |  62 +++
>  server/src/acl.rs                            |   6 +
>  server/src/api/remote_tasks.rs               |  36 +-
>  server/src/api/resources.rs                  | 152 +++++-
>  server/src/lib.rs                            |   1 +
>  server/src/metric_collection/top_entities.rs |   5 +
>  server/src/remote_tasks/mod.rs               |  39 +-
>  server/src/resource_cache.rs                 |   3 +-
>  server/src/test_support/fake_remote.rs       |   1 +
>  server/src/views/mod.rs                      |   4 +
>  server/src/views/tests.rs                    | 486 +++++++++++++++++++
>  server/src/views/view_filter.rs              | 225 +++++++++
>  ui/src/dashboard/mod.rs                      |   2 +-
>  ui/src/sdn/zone_tree.rs                      |   2 +-
>  19 files changed, 1157 insertions(+), 45 deletions(-)
>  create mode 100644 lib/pdm-api-types/src/views.rs
>  create mode 100644 lib/pdm-config/src/views.rs
>  create mode 100644 server/src/views/mod.rs
>  create mode 100644 server/src/views/tests.rs
>  create mode 100644 server/src/views/view_filter.rs
> 
> 
> Summary over all repositories:
>   19 files changed, 1157 insertions(+), 45 deletions(-)
> 
> -- 
> Generated by murpp 0.9.0


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel