all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v4 0/3] fix 2515 use size defaults
Date: Fri, 17 Nov 2023 09:30:55 +0100	[thread overview]
Message-ID: <s8ozfzcagts.fsf@proxmox.com> (raw)
In-Reply-To: <20230929130203.3902108-1-a.lauterer@proxmox.com>

Tested on a 3-node cluster.

Set `osd_pool_default_min_size` and `osd_pool_default_size` on
ceph.confg to min_size=1 size=2, created a pool using the web UI and it
has the correct size after creation.

One things I noticed is that if you set them to, for example min_size=3,
size=2, no errors will be displayed in the web UI until the creation
fails with:

    Could not set: min_size, size

I am not sure if this should be catched a bit earlier in the web UI, in
the same way we catch size=1 and prevent the creation of the pool. It is
an invalid configuration file after all.


Tested `ceph config set X value`. The values in ceph.conf indeed take
priority as per the commit message. When the values are not present in
ceph.conf, the values from the config DB take preference over the 3/2
default as expected.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

Aaron Lauterer <a.lauterer@proxmox.com> writes:

> The main goal of this series is to improve the handling of configured
> default size & min_size values when creating a new Ceph Pool in the GUI.
>
> A new Ceph API endpoint, 'cfg/value', is added. It allows us to fetch
> values for config keys that are set either in the config DB of Ceph or
> in the ceph.conf file.
>
> changes since
> v3: rebased
>
> v2:
> * API rework has been already applied
> * cleaned up JS code to set default values right where we get them from
>   the API instead of at multiple places in the CephPoolInputPanel
>   itself.
>
> Aaron Lauterer (3):
>   api: ceph: add endpoint to fetch config keys
>   fix #2515: ui: ceph pool create: use configured defaults for size and
>     min_size
>   ui: ceph pool edit: rework with controller and formulas
>
>  PVE/API2/Ceph/Cfg.pm      |  82 ++++++++++++++++++++++
>  www/manager6/ceph/Pool.js | 144 +++++++++++++++++++++++++++++---------
>  2 files changed, 191 insertions(+), 35 deletions(-)


--
Maximiliano




  parent reply	other threads:[~2023-11-17  9:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 13:02 Aaron Lauterer
2023-09-29 13:02 ` [pve-devel] [PATCH manager v4 1/3] api: ceph: add endpoint to fetch config keys Aaron Lauterer
2023-09-29 13:02 ` [pve-devel] [PATCH manager v4 2/3] fix #2515: ui: ceph pool create: use configured defaults for size and min_size Aaron Lauterer
2023-09-29 13:02 ` [pve-devel] [PATCH manager v4 3/3] ui: ceph pool edit: rework with controller and formulas Aaron Lauterer
2023-11-17  8:30 ` Maximiliano Sandoval [this message]
2023-11-21 13:40 ` [pve-devel] applied: [PATCH manager v4 0/3] fix 2515 use size defaults Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8ozfzcagts.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal