From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs
Date: Fri, 02 Jan 2026 16:27:20 +0100 [thread overview]
Message-ID: <s8oy0mgm3vr.fsf@proxmox.com> (raw)
In-Reply-To: <20260102143544.354066-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Fri, 2 Jan 2026 15:35:35 +0100")
Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
> ..and add more logging when issuing fsfreeze guest commands.
>
> The new setting takes precedence over freeze-fs-on-backup and deprecates the
> former.
>
> - At the moment taking a snapshot without RAM does not log whether there was a
> freeze/thaw, we add logs when issuing freezes/thaws.
>
> - The patch does not result in an extra log line when making a Backup in
> snapshot mode.
>
> - When it is easy to do so, we log if the fsfreeze command was not issued due to
> mismatch between the agent running and the config, e.g. when say that we
> skipped it if the agent is enabled bu the configuration says we shouldn't.
@fiona, one thing I just noticed is that `import_from_volid` calls
clone_disk() with $src_config->{'agent'} as an argument.
- Is this OK as-is, or should it also take into account the new
guest-fsfreeze setting?
- What operations would trigger this codepath?
--
Maximiliano
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-02 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 14:35 Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 1/8] add a guest-fsfreeze qga setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 2/8] api: clone_vm: follow guest-fsfreeze setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 3/8] fix #1964: follow guest-fsfreeze setting on check freeze needed Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 4/8] agent: add a guest_fsthaw helper Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 5/8] port users of guest-fsfreeze-thaw users to helper Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 6/8] block job: log when a fsfreeze could not happen Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 7/8] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 8/8] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH guest-common v4 1/1] abstract config: print when {, un}freezing a fs Maximiliano Sandoval
2026-01-02 15:27 ` Maximiliano Sandoval [this message]
2026-01-02 15:36 ` [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oy0mgm3vr.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.