From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: superseded: [PATCH backup v2 0/3] fix #7054: client: remove trailing newlines from credentials
Date: Mon, 23 Feb 2026 11:07:53 +0100 [thread overview]
Message-ID: <s8oy0kjwz5y.fsf@proxmox.com> (raw)
In-Reply-To: <20260220123818.365489-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Fri, 20 Feb 2026 13:38:13 +0100")
Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
> See the first commit for more details.
>
> This was tested with proxmox-backup-client making a login/backup using different
> credentials with and without newlines. The commands were similar to the
> systemd-run commands at the Backup Client Usage docs.
>
> I did not find a way to create the keyfile with newlines in its password using
> proxmox-backup-client since it reads from the tty stdin, but surely it could be
> created manually. Perhaps it is safe-ish to also remove trailing control
> characters from the encryption password but this seems a safer approach for now.
>
> Diferences from v1:
> - Always do an extra allocation to keep the code clean
> - Rename password to blob
> - Only strip newlines on passwords
Superseded-by: https://lore.proxmox.com/all/20260223093710.36009-1-m.sandoval@proxmox.com/
--
Maximiliano
prev parent reply other threads:[~2026-02-23 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 12:38 Maximiliano Sandoval
2026-02-20 12:38 ` [PATCH backup v2 1/3] " Maximiliano Sandoval
2026-02-23 7:55 ` Christian Ebner
2026-02-23 9:33 ` Maximiliano Sandoval
2026-02-20 12:38 ` [PATCH backup v2 2/3] docs: client: document further password constrains Maximiliano Sandoval
2026-02-23 7:58 ` Christian Ebner
2026-02-20 12:38 ` [PATCH backup v2 3/3] client: rename password to blob Maximiliano Sandoval
2026-02-23 10:07 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oy0kjwz5y.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.