all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-offline-mirror 2/2] add missing subscription setting for ceph enterprise repos
Date: Tue, 21 Nov 2023 16:49:01 +0100	[thread overview]
Message-ID: <s8owmub9ka9.fsf@proxmox.com> (raw)
In-Reply-To: <20231121144818.664549-2-s.sterz@proxmox.com>


Tested both patches. They generate the correct configurations for quincy
and reef.

```
mirror: ceph_quincy_bookworm
	architectures amd64
	architectures all
	base-dir /var/lib/proxmox-offline-mirror/mirrors/
	ignore-errors false
	key-path /etc/apt/trusted.gpg.d/proxmox-release-bookworm.gpg
	repository deb https://enterprise.proxmox.com/debian/ceph-quincy bookworm enterprise
	sync false
	use-subscription pve
	verify false

mirror: ceph_reef_bookworm
	architectures amd64
	architectures all
	base-dir /var/lib/proxmox-offline-mirror/mirrors/
	ignore-errors false
	key-path /etc/apt/trusted.gpg.d/proxmox-release-bookworm.gpg
	repository deb https://enterprise.proxmox.com/debian/ceph-reef bookworm enterprise
	sync false
	use-subscription pve
	verify false
```

I can confirm that without setting use-subscription it won't be possible
to sync the Ceph enteriprise repo and the first patch in this series
fixes it.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

Stefan Sterz <s.sterz@proxmox.com> writes:

> when setting up a ceph enterprise repo we didn't add a subscription
> for it. this commit adds a pve subscription so that pom can properly
> authenticate itself when mirroring the ceph enterprise repos.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  src/bin/proxmox-offline-mirror.rs | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/src/bin/proxmox-offline-mirror.rs b/src/bin/proxmox-offline-mirror.rs
> index 2f2e782..d029d3d 100644
> --- a/src/bin/proxmox-offline-mirror.rs
> +++ b/src/bin/proxmox-offline-mirror.rs
> @@ -296,10 +296,13 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
>                          read_selection_from_tty("Select repository variant", variants, Some(0))?;
>
>                      match variant {
> -                        ProxmoxVariant::Enterprise => (
> -                            "https://enterprise.proxmox.com/debian/ceph",
> -                            "enterprise".to_string(),
> -                        ),
> +                        ProxmoxVariant::Enterprise => {
> +                            use_subscription = Some(ProductType::Pve);
> +                            (
> +                                "https://enterprise.proxmox.com/debian/ceph",
> +                                "enterprise".to_string(),
> +                            )
> +                        }
>                          ProxmoxVariant::NoSubscription => (
>                              "http://download.proxmox.com/debian/ceph",
>                              "no-subscription".to_string(),


--
Maximiliano




  reply	other threads:[~2023-11-21 15:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 14:48 [pbs-devel] [PATCH proxmox-offline-mirror 1/2] add support for ceph reef Stefan Sterz
2023-11-21 14:48 ` [pbs-devel] [PATCH proxmox-offline-mirror 2/2] add missing subscription setting for ceph enterprise repos Stefan Sterz
2023-11-21 15:49   ` Maximiliano Sandoval [this message]
2023-11-25 16:19 ` [pbs-devel] applied: [PATCH proxmox-offline-mirror 1/2] add support for ceph reef Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8owmub9ka9.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal