Re: [pbs-devel] [PATCH proxmox-backup] report: better hardware and system utilization overview.

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Hannes Duerr <h.duerr@proxmox.com> writes:

> instead of `ls -l /dev/disk/by-id /dev/disk/by-path` the command
> `ls -l /dev/disk/by-*` is beeing used which displays the discs not only
> by-id and by-path, but also by-diskseq, by-label, by-uuid, and
> by-partuuid, which can be very helpful when assigning iSCSI and
> multipath devices.
>
> `dmidecode -t bios` outputs the current BIOS version and which allows to
> determine whether certain fixes have already been implemented in the
> version or not.
>
> `lscpu` provides a good overview of the CPU being used, its flags, and
> existing/non-existing mitigations.
>
> `lspci -nnk` displays all PCI devices and the drivers used, which is often
> helpful when troubleshooting.
>
> `ip -details -statistics a` provides a detailed overview of the
> available interfaces and statistics since the last boot. This
> information is often helpful in addressing performance issues and
> assessments.
>
> Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
> ---
>  src/server/report.rs | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/server/report.rs b/src/server/report.rs
> index ca5f04fc..64a209ec 100644
> --- a/src/server/report.rs
> +++ b/src/server/report.rs
> @@ -82,10 +82,14 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
>                  "+HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN",
>              ],
>          ),
> -        ("ls", vec!["-l", "/dev/disk/by-id", "/dev/disk/by-path"]),
> +        ("ls", vec!["-l", "/dev/disk/by-*"]),
>          ("zpool", vec!["status"]),
>          ("zfs", vec!["list"]),
>          ("arcstat", vec![]),
> +        ("dmidecode", vec!["-t", "bios"]),
> +        ("lscpu", vec![]),
> +        ("lspci", vec!["-nnk"]),
> +        ("ip", vec!["-details", "-statistics", "a"]),
>      ]
>  }

I tested this patch and the report contains:

``````
$ `ls -l /dev/disk/by-*`
```

```
STDERR:
```
ls: cannot access '/dev/disk/by-*': No such file or directory

```
``````

perhaps we cannot use a glob pattern in this environment? Note that the
command runs just fine with bash (over ssh) on the machine where this
was tested.

Other than that, this would be an excellent addition.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel