From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/2] support eligibility checking in the cli
Date: Tue, 16 Dec 2025 09:57:33 +0100 [thread overview]
Message-ID: <s8oldj23ite.fsf@proxmox.com> (raw)
In-Reply-To: <DEZHOOPHC3IV.JQ4CTIZIPN3W@proxmox.com> (Lukas Wagner's message of "Tue, 16 Dec 2025 09:14:19 +0100")
"Lukas Wagner" <l.wagner@proxmox.com> writes:
> On Mon Dec 15, 2025 at 5:21 PM CET, Shannon Sterz wrote:
>> these two patches add commands for query and updating the enterprise
>> support eligibility status of pdm itself as well as updating it. it also
>> includes a patch to add such a command to the system report. for a
>> reasoning on why this naming was chosen see commit 1.
>>
>> Shannon Sterz (2):
>> cli: admin: add `support-eligibility` subcommand
>> server: add the new `support-eligibility` subcommand to the report
>>
>
> Code looks good from what I can tell.
>
> Maybe we should go with a simpler (albeit, more generic)
> `support-status` command? 'eligibilty' could be a bit hard to
> type/remember for some.
>
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Looks good to me.
I do agree that it might be a bit harder to type, but I guess one can
use auto-complete too.
Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
--
Maximiliano
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-16 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 16:21 Shannon Sterz
2025-12-15 16:21 ` [pdm-devel] [PATCH datacenter-manager 1/2] cli: admin: add `support-eligibility` subcommand Shannon Sterz
2025-12-15 16:21 ` [pdm-devel] [PATCH datacenter-manager 2/2] server: add the new `support-eligibility` subcommand to the report Shannon Sterz
2025-12-16 8:14 ` [pdm-devel] [PATCH datacenter-manager 0/2] support eligibility checking in the cli Lukas Wagner
2025-12-16 8:57 ` Maximiliano Sandoval [this message]
2025-12-16 17:24 ` [pdm-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oldj23ite.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.