all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH-SERIES qemu-server/docs 0/2] efi enroll: small improvements to documentation
Date: Wed, 18 Mar 2026 11:25:36 +0100	[thread overview]
Message-ID: <s8oikato2n3.fsf@toolbox> (raw)
In-Reply-To: <20260318093307.31645-1-f.ebner@proxmox.com> (Fiona Ebner's message of "Wed, 18 Mar 2026 10:32:57 +0100")

Fiona Ebner <f.ebner@proxmox.com> writes:

> qemu-server:
>
> Fiona Ebner (1):
>   start vm: check efi vars: clarify when to run the commands for
>     BitLocker
>
>  src/PVE/QemuServer.pm | 2 ++
>  1 file changed, 2 insertions(+)
>
>
> pve-docs:
>
> Fiona Ebner (1):
>   qm: bios/uefi: certificate expiration: mention steps for BitLocker
>     earlier
>
>  qm.adoc | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
>
>
> Summary over all repositories:
>   2 files changed, 15 insertions(+), 11 deletions(-)

While testing this patch it was not clear to me whether the order of
operations mattered after reading the documentation.

Given how sensitive this operation might be it is better to err on the
side of being precise.

Please consider this,

Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano




      parent reply	other threads:[~2026-03-18 10:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  9:32 Fiona Ebner
2026-03-18  9:32 ` [PATCH qemu-server 1/2] start vm: check efi vars: clarify when to run the commands for BitLocker Fiona Ebner
2026-03-18  9:32 ` [PATCH docs 2/2] qm: bios/uefi: certificate expiration: mention steps for BitLocker earlier Fiona Ebner
2026-03-18 10:25 ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8oikato2n3.fsf@toolbox \
    --to=m.sandoval@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal