From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH ha-manager] watchdog-mux: Restore if guard for watchdog updates
Date: Wed, 23 Jul 2025 12:58:19 +0200 [thread overview]
Message-ID: <s8oa54v2myc.fsf@proxmox.com> (raw)
In-Reply-To: <20250723105518.272549-1-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Wed, 23 Jul 2025 12:54:37 +0200")
Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
> In commit c26b474 the if condition was removed in favor of the if guard
> on the higher level. However, this introduced functional change, the
> watchdog now updates immediately after update_watchdog is set to 0,
> potentially causing fencing after x+1 seconds instead of x seconds. This
> behavior is incorrect because updating the watchdog after declaring no
> more updates makes no logical sense.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
I forgot to mention that this change was
Reported-by: Friedrich Weber <f.weber@proxmox.com>
--
Maximiliano
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-23 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 10:54 Maximiliano Sandoval
2025-07-23 10:58 ` Maximiliano Sandoval [this message]
2025-07-29 19:38 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oa54v2myc.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.