Re: [pbs-devel] applied-series: [PATCH proxmox 01/10] clippy: remove needless borrow

From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied-series: [PATCH proxmox 01/10] clippy: remove needless borrow
Date: Fri, 09 Aug 2024 13:11:24 +0200	[thread overview]
Message-ID: <s8o8qx6ar37.fsf@proxmox.com> (raw)
In-Reply-To: <71a9f6ff-44b0-4ead-bd66-1344274e7f7a@proxmox.com> (Thomas Lamprecht's message of "Wed, 7 Aug 2024 20:59:37 +0200")

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> On 07/08/2024 09:43, Maximiliano Sandoval wrote:
>> Fixes the clippy warning:
>> 
>> warning: this expression borrows a value the compiler would automatically borrow
>>    --> proxmox-apt/src/repositories/file/sources_parser.rs:111:40
>>     |
>> 111 | ...                   types.push((&package_type[..]).parse()?);
>>     |                                  ^^^^^^^^^^^^^^^^^^^ help: change this to: `package_type[..]`
>>     |
>>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
>>     = note: `#[warn(clippy::needless_borrow)]` on by default
>> 
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>
> applied series with Lukas' R-b, thanks!

Thanks! I don't see the first commit in the series ()`clippy: remove
needless borrow`) in the repository, is it possible that it slipped by?

-- 
Maximiliano

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel