all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's
Date: Thu, 14 Dec 2023 11:26:44 +0100	[thread overview]
Message-ID: <s8o7clhys5m.fsf@proxmox.com> (raw)
In-Reply-To: <20231123160902.282661-1-l.wagner@proxmox.com>


Lukas Wagner <l.wagner@proxmox.com> writes:

>   - Switch order of 'mailto' and 'mailnotification' field
>   - When mode is 'auto', disable 'mailtnotification' field
>   - When mode is 'auto' and 'mailto' is empty, show
>     hint that the notification system will be used
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>

Tested both commits, they do what they promise.

> +	let notificationSystemHint = Ext.create({
> +	    xtype: 'displayfield',
> +	    padding: '0 0 0 5',
> +	    userCls: 'pmx-hint',
> +	    hidden: true,
> +	    value: gettext('No email configured, the notification system will be used'),
> +	    viewModel,
> +	    bind: {
> +		hidden: '{!hintTextVisible}',

I think the `pmx-hint` being displayed as yellow suggests it is a
warning/error rather than a hint. I wonder if there is a better
approach, as this is certainly not a warning.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
--
Maximiliano




  parent reply	other threads:[~2023-12-14 10:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23 16:09 Lukas Wagner
2023-11-23 16:09 ` [pve-devel] [PATCH manager 2/2] ui: one-off backup: show hint if notification-system is used Lukas Wagner
2023-12-14 10:26 ` Maximiliano Sandoval [this message]
2024-04-11  7:44   ` [pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's Thomas Lamprecht
2024-04-15  9:27     ` Lukas Wagner
2024-01-08 10:43 ` Lukas Wagner
2024-02-16 10:35   ` Lukas Wagner
2024-04-09  9:22 ` Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8o7clhys5m.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal