[pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[Maximiliano Sandoval]

Whenever a filesystem is selected we show the size selection stack page.

At the moment entering any raid setup, then entering the Advanced
Options page and then selecting any non-raid setup will show the
raiddisk page since it is still the visible child.

Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 1 +
 1 file changed, 1 insertion(+)

diff --git a/proxinstall b/proxinstall
index fe7e29f..5e61e9b 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1358,6 +1358,7 @@ sub create_hdoption_view {
 	    $options_stack->set_visible_child_name("raiddisk");
 	} else {
 	    $target_hd_label->set_text("Target Harddisk");
+	    $options_stack->set_visible_child_name("hdsize");
 	}
 
 	if ($raid) {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[Maximiliano Sandoval]

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> Whenever a filesystem is selected we show the size selection stack page.
>
> At the moment entering any raid setup, then entering the Advanced
> Options page and then selecting any non-raid setup will show the
> raiddisk page since it is still the visible child.
>
> Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

ping.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[Christoph Heiss]

On Tue Mar 4, 2025 at 11:49 AM CET, Maximiliano Sandoval wrote:
> Whenever a filesystem is selected we show the size selection stack page.
>
> At the moment entering any raid setup, then entering the Advanced
> Options page and then selecting any non-raid setup will show the
> raiddisk page since it is still the visible child.

While testing this, I cannot seem to reproduce the original problem on
the latest PVE 8.3-1 ISO.

In the GUI, clicking on "Options" besides the target harddisk, then in
the dialog selecting e.g. "zfs (RAID1)", going to the "Advanced Options"
tab and then selecting e.g. "ext4" above, yields the normal disk sizing
options tab as expected.

On the main disk selection page, the dropdown is also updated
accordingly.

Or is some other combination of inputs required to trigger this bug?
This is just based upon the patch description.

>
> Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  proxinstall | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/proxinstall b/proxinstall
> index fe7e29f..5e61e9b 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -1358,6 +1358,7 @@ sub create_hdoption_view {
>  	    $options_stack->set_visible_child_name("raiddisk");
>  	} else {
>  	    $target_hd_label->set_text("Target Harddisk");
> +	    $options_stack->set_visible_child_name("hdsize");
>  	}
>
>  	if ($raid) {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[Maximiliano Sandoval]

"Christoph Heiss" <c.heiss@proxmox.com> writes:

> On Tue Mar 4, 2025 at 11:49 AM CET, Maximiliano Sandoval wrote:
>> Whenever a filesystem is selected we show the size selection stack page.
>>
>> At the moment entering any raid setup, then entering the Advanced
>> Options page and then selecting any non-raid setup will show the
>> raiddisk page since it is still the visible child.
>
> While testing this, I cannot seem to reproduce the original problem on
> the latest PVE 8.3-1 ISO.
> In the GUI, clicking on "Options" besides the target harddisk, then in
> the dialog selecting e.g. "zfs (RAID1)", going to the "Advanced Options"
> tab and then selecting e.g. "ext4" above, yields the normal disk sizing
> options tab as expected.


You are right, I just noticed that not all raid setups reproduce this
issue. Selecting the advanced options in "btrfs (RAID10)" and going back
to ext4, for example, reproduces the issue.

> On the main disk selection page, the dropdown is also updated
> accordingly.
>
> Or is some other combination of inputs required to trigger this bug?
> This is just based upon the patch description.

The commit message should be updated, I will do that if there is a need
for v2.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[Thomas Lamprecht]

Am 01.04.25 um 15:09 schrieb Maximiliano Sandoval:
> The commit message should be updated, I will do that if there is a need
> for v2.

Can you please either send out a v2 or propose a new commit message that I
can just copy+paste in full?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

[Maximiliano Sandoval]

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> Am 01.04.25 um 15:09 schrieb Maximiliano Sandoval:
>> The commit message should be updated, I will do that if there is a need
>> for v2.
>
> Can you please either send out a v2 or propose a new commit message that I
> can just copy+paste in full?

v2 at https://lore.proxmox.com/pve-devel/20250404083957.107263-1-m.sandoval@proxmox.com/T/#u.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel