all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible
Date: Wed, 23 Jul 2025 14:08:58 +0200	[thread overview]
Message-ID: <s8o4iv32jol.fsf@proxmox.com> (raw)
In-Reply-To: <175327187456.3485344.14076148566441093063.b4-ty@proxmox.com> (Thomas Lamprecht's message of "Wed, 23 Jul 2025 13:57:56 +0200")

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> On Wed, 23 Jul 2025 13:50:15 +0200, Christian Ebner wrote:
>> Commit 90723828 ("api: backup: add no-cache flag to bypass local
>> datastore cache") introduced the additional flag to request bypassing
>> of the datastore cache by the Proxmox Backup Server.
>> 
>> The flag is however included in the backup api request parameters,
>> which is incompatible with older version of the server.
>> 
>> [...]
>
> Applied, thanks!
>
> [1/1] client: backup writer: make no-cache parameter backwards compatible
>       commit: c763a0e9dff12acda8a84c70df08e637ba2a67bf

A bit late, but I can confirm this fixes encrypted backups of containers
(against a pbs server running 3.4.3) in pve for me.

-- 
Maximiliano


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


WARNING: multiple messages have this Message-ID
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [pbs-devel] applied: [PATCH proxmox-backup] client: backup writer: make no-cache parameter backwards compatible
Date: Wed, 23 Jul 2025 14:08:58 +0200	[thread overview]
Message-ID: <s8o4iv32jol.fsf@proxmox.com> (raw)
In-Reply-To: <175327187456.3485344.14076148566441093063.b4-ty@proxmox.com> (Thomas Lamprecht's message of "Wed, 23 Jul 2025 13:57:56 +0200")

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> On Wed, 23 Jul 2025 13:50:15 +0200, Christian Ebner wrote:
>> Commit 90723828 ("api: backup: add no-cache flag to bypass local
>> datastore cache") introduced the additional flag to request bypassing
>> of the datastore cache by the Proxmox Backup Server.
>> 
>> The flag is however included in the backup api request parameters,
>> which is incompatible with older version of the server.
>> 
>> [...]
>
> Applied, thanks!
>
> [1/1] client: backup writer: make no-cache parameter backwards compatible
>       commit: c763a0e9dff12acda8a84c70df08e637ba2a67bf

A bit late, but I can confirm this fixes encrypted backups of containers
(against a pbs server running 3.4.3) in pve for me.

-- 
Maximiliano


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-07-23 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 11:50 [pbs-devel] " Christian Ebner
2025-07-23 11:57 ` [pbs-devel] applied: " Thomas Lamprecht
2025-07-23 11:57   ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2025-07-23 12:08   ` Maximiliano Sandoval [this message]
2025-07-23 12:08     ` [pve-devel] [pbs-devel] applied: " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8o4iv32jol.fsf@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal