[PATCH manager] ceph: init: drop deprecated pg_bits parameter

[PATCH manager] ceph: init: drop deprecated pg_bits parameter

[Kefu Chai]

The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the
underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed
from Ceph in v13.0.2.  The implementation was made a no-op at that point,
with a TODO to remove the parameter declaration in PVE 9.

We are now at pve-manager 9.1.6.  The minimum Ceph version supported by
pveceph init is Nautilus (v14), which is already past the point where
these options existed, so the parameter has been a guaranteed no-op on
every cluster PVE 9 can manage.  Remove it along with the adjacent
dead-code comments.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 PVE/API2/Ceph.pm | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 231b751c..f59caf16 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -161,17 +161,6 @@ __PACKAGE__->register_method({
                 minimum => 1,
                 maximum => 7,
             },
-            # TODO: deprecrated, remove with PVE 9
-            pg_bits => {
-                description => "Placement group bits, used to specify the "
-                    . "default number of placement groups.\n\nDepreacted. This "
-                    . "setting was deprecated in recent Ceph versions.",
-                type => 'integer',
-                default => 6,
-                optional => 1,
-                minimum => 6,
-                maximum => 14,
-            },
             disable_cephx => {
                 description => "Disable cephx authentication.\n\n"
                     . "WARNING: cephx is a security feature protecting against "
@@ -238,9 +227,6 @@ __PACKAGE__->register_method({
                         'mon_allow_pool_delete' => 'true',
                     };
 
-                    # this does not work for default pools
-                    #'osd pool default pg num' => $pg_num,
-                    #'osd pool default pgp num' => $pg_num,
                 }
 
                 if ($auth eq 'cephx') {
-- 
2.47.3

Re: [PATCH manager] ceph: init: drop deprecated pg_bits parameter

[Maximiliano Sandoval]

Kefu Chai <k.chai@proxmox.com> writes:

> The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the
> underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed
> from Ceph in v13.0.2.  The implementation was made a no-op at that point,
> with a TODO to remove the parameter declaration in PVE 9.
>
> We are now at pve-manager 9.1.6.  The minimum Ceph version supported by
> pveceph init is Nautilus (v14), which is already past the point where
> these options existed, so the parameter has been a guaranteed no-op on
> every cluster PVE 9 can manage.  Remove it along with the adjacent
> dead-code comments.
>
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>

Since the parameter is only used during ceph initialization, this looks
OK to me.

Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano

Re: [PATCH manager] ceph: init: drop deprecated pg_bits parameter

[Thomas Lamprecht]

Am 25.03.26 um 05:30 schrieb Kefu Chai:
> The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the
> underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed
> from Ceph in v13.0.2.  The implementation was made a no-op at that point,
> with a TODO to remove the parameter declaration in PVE 9.
> 
> We are now at pve-manager 9.1.6.  The minimum Ceph version supported by
> pveceph init is Nautilus (v14), which is already past the point where
> these options existed, so the parameter has been a guaranteed no-op on
> every cluster PVE 9 can manage.  Remove it along with the adjacent
> dead-code comments.
> 
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
> ---
>  PVE/API2/Ceph.pm | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
> index 231b751c..f59caf16 100644
> --- a/PVE/API2/Ceph.pm
> +++ b/PVE/API2/Ceph.pm
> @@ -161,17 +161,6 @@ __PACKAGE__->register_method({
>                  minimum => 1,
>                  maximum => 7,
>              },
> -            # TODO: deprecrated, remove with PVE 9
> -            pg_bits => {
> -                description => "Placement group bits, used to specify the "
> -                    . "default number of placement groups.\n\nDepreacted. This "
> -                    . "setting was deprecated in recent Ceph versions.",
> -                type => 'integer',
> -                default => 6,
> -                optional => 1,
> -                minimum => 6,
> -                maximum => 14,
> -            },

Any removal of an API parameters this is still a breaking API change,
the chance to do that was before 9.0 release, not now. Next chance is
mid next year before first public stable PVE 10.0 release.
As some API integration might still send this along, and then suddenly
stop working during a minor release if we push this out. The only
exception here would be if passing this parameter already caused an
unconditional error with the current ceph baseline version in PVE 9,
which would be squid.

The code below can be still dropped in any case though, making the
param no-op until it's actual removal.

>              disable_cephx => {
>                  description => "Disable cephx authentication.\n\n"
>                      . "WARNING: cephx is a security feature protecting against "
> @@ -238,9 +227,6 @@ __PACKAGE__->register_method({
>                          'mon_allow_pool_delete' => 'true',
>                      };
>  
> -                    # this does not work for default pools
> -                    #'osd pool default pg num' => $pg_num,
> -                    #'osd pool default pgp num' => $pg_num,
>                  }
>  
>                  if ($auth eq 'cephx') {