From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Kefu Chai <k.chai@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ceph: init: drop deprecated pg_bits parameter
Date: Thu, 26 Mar 2026 12:45:28 +0100 [thread overview]
Message-ID: <s8o4im2q0fb.fsf@toolbox> (raw)
In-Reply-To: <20260325043120.2289935-1-k.chai@proxmox.com> (Kefu Chai's message of "Wed, 25 Mar 2026 12:31:20 +0800")
Kefu Chai <k.chai@proxmox.com> writes:
> The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the
> underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed
> from Ceph in v13.0.2. The implementation was made a no-op at that point,
> with a TODO to remove the parameter declaration in PVE 9.
>
> We are now at pve-manager 9.1.6. The minimum Ceph version supported by
> pveceph init is Nautilus (v14), which is already past the point where
> these options existed, so the parameter has been a guaranteed no-op on
> every cluster PVE 9 can manage. Remove it along with the adjacent
> dead-code comments.
>
> Signed-off-by: Kefu Chai <k.chai@proxmox.com>
Since the parameter is only used during ceph initialization, this looks
OK to me.
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
--
Maximiliano
next prev parent reply other threads:[~2026-03-26 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 4:31 Kefu Chai
2026-03-26 11:45 ` Maximiliano Sandoval [this message]
2026-03-26 12:55 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8o4im2q0fb.fsf@toolbox \
--to=m.sandoval@proxmox.com \
--cc=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.