From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup v3] fix-3699: pbs-client/tools: use xdg basedirectories for tmp files
Date: Mon, 12 Feb 2024 10:46:53 +0100 [thread overview]
Message-ID: <s8o34tyf1rg.fsf@proxmox.com> (raw)
In-Reply-To: <4a7cffae-72d9-440c-8997-b5450b8a9339@proxmox.com>
Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
>> +pub fn create_tmp_file() -> std::io::Result<std::fs::File> {
>
> Hmm, wondering if "create_xdg_tmp_file" could be slightly better here,
> but the fallback behavior is not the best fit with that name, so no
> hard feelings from my side.
Since this indeed can create files outside of XDG_CACHE_HOME I opted for
not putting `xdg` in the fn name. It is also a bit more future-proof in
case the function is refactored/modified. No strong opinions anyways.
I will send a v4 today.
--
Maximiliano
prev parent reply other threads:[~2024-02-12 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 13:49 Maximiliano Sandoval
2024-02-05 16:15 ` Thomas Lamprecht
2024-02-12 9:46 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8o34tyf1rg.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.