all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] live import: correctly generate blockdev
@ 2025-08-14 13:06 Fiona Ebner
  2025-08-25 10:08 ` [pve-devel] applied: " Wolfgang Bumiller
  0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2025-08-14 13:06 UTC (permalink / raw)
  To: pve-devel

The throttle node is generated later above the alloc-track block node,
so generating the alloc-track backing block node needs to happen with
'no-throttle' to avoid a duplicate node name and avoid an additional
throttle node in the graph.

Reported in the community forum:
https://forum.proxmox.com/threads/169766/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 78cfad62..f263fedb 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -7379,7 +7379,7 @@ sub live_import_from_files {
             my ($interface, $index) = PVE::QemuServer::Drive::parse_drive_interface($dev);
             my $drive = { file => $volid, interface => $interface, index => $index };
             my $blockdev = PVE::QemuServer::Blockdev::generate_drive_blockdev(
-                $storecfg, $drive, $machine_version, {},
+                $storecfg, $drive, $machine_version, { 'no-throttle' => 1 },
             );
             $live_restore_backing->{$dev}->{blockdev} = $blockdev;
         } else {
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH qemu-server] live import: correctly generate blockdev
  2025-08-14 13:06 [pve-devel] [PATCH qemu-server] live import: correctly generate blockdev Fiona Ebner
@ 2025-08-25 10:08 ` Wolfgang Bumiller
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2025-08-25 10:08 UTC (permalink / raw)
  To: Fiona Ebner; +Cc: pve-devel

applied, thanks

On Thu, Aug 14, 2025 at 03:06:00PM +0200, Fiona Ebner wrote:
> The throttle node is generated later above the alloc-track block node,
> so generating the alloc-track backing block node needs to happen with
> 'no-throttle' to avoid a duplicate node name and avoid an additional
> throttle node in the graph.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/169766/
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 78cfad62..f263fedb 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -7379,7 +7379,7 @@ sub live_import_from_files {
>              my ($interface, $index) = PVE::QemuServer::Drive::parse_drive_interface($dev);
>              my $drive = { file => $volid, interface => $interface, index => $index };
>              my $blockdev = PVE::QemuServer::Blockdev::generate_drive_blockdev(
> -                $storecfg, $drive, $machine_version, {},
> +                $storecfg, $drive, $machine_version, { 'no-throttle' => 1 },
>              );
>              $live_restore_backing->{$dev}->{blockdev} = $blockdev;
>          } else {
> -- 
> 2.47.2


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-25 10:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-14 13:06 [pve-devel] [PATCH qemu-server] live import: correctly generate blockdev Fiona Ebner
2025-08-25 10:08 ` [pve-devel] applied: " Wolfgang Bumiller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal