From: Gabriel Goller <g.goller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] improve push sync job log messages
Date: Thu, 21 Nov 2024 17:06:06 +0100 [thread overview]
Message-ID: <rwve3xs5b555w4dufdwjr4srakuve77oqswvkwftiy6qrgdeso@2z5qkvgqxbge> (raw)
In-Reply-To: <20241121154337.471425-1-c.ebner@proxmox.com>
I think I'd be nice if we use `.context()` instead of `format_err` and
debug print ("{err:?}") instead of default ("{}") here. As these
messages are all errors they shouldn't appear too often in the log and
if an error happens, you get much more information.
What do you think?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-21 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 15:43 Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 1/4] server: push: fix needless borrow clippy warning Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 2/4] server: push: consistently use remote over target for error messages Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 3/4] server: push: add error context to all target api calls Christian Ebner
2024-11-22 9:01 ` Fabian Grünbichler
2024-11-22 10:11 ` Christian Ebner
2024-11-21 15:43 ` [pbs-devel] [PATCH proxmox-backup 4/4] server: push: various smaller improvements to error messages Christian Ebner
2024-11-21 16:06 ` Gabriel Goller [this message]
2024-11-21 16:26 ` [pbs-devel] [PATCH proxmox-backup 0/4] improve push sync job log messages Christian Ebner
2024-11-21 17:04 ` Gabriel Goller
2024-11-21 19:32 ` Fabian Grünbichler
2024-11-22 8:41 ` Christian Ebner
2024-11-22 12:28 ` Christian Ebner
2024-11-22 9:04 ` [pbs-devel] partially-applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rwve3xs5b555w4dufdwjr4srakuve77oqswvkwftiy6qrgdeso@2z5qkvgqxbge \
--to=g.goller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.