From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Daniel Herzig <d.herzig@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH esxi-import-tools] listvms: exclude VMs without datastore_name from manifest.json.
Date: Tue, 8 Apr 2025 11:17:12 +0200 [thread overview]
Message-ID: <rf464d4lpsr6gbpgcrv6233yq56r3fgjvxzfcv6seslqt7wk6h@kdp6jnu7sylc> (raw)
In-Reply-To: <20250407150422.293994-1-d.herzig@proxmox.com>
On Mon, Apr 07, 2025 at 05:04:22PM +0200, Daniel Herzig wrote:
> On newer ESXI-8.x.y versions, the diskless vCLS machines in an
> ESXI-cluster are not stored on a datastore anymore.
>
> Instead, they are placed under `/var/run/crx` on the ESXI-hosts'
> filesystem. This can lead to issues with the ESXI-storage not being
> activated on the PVE-side [0].
>
> This commit changes the default behaviour of `manifest.json` creation by
> excluding any machine that has an empty datastore-string in its config
> and by that prevents querying a file that we cannot reach anyway.
>
> [0] https://forum.proxmox.com/threads/new-import-wizard-available-for-migrating-vmware-esxi-based-virtual-machines.144023/post-759288
>
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
> ---
> This acts silently for now, if we'd prefer logging exclusion
> of these VMs, please drop an idea!
>
> listvms.py | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/listvms.py b/listvms.py
> index a2fb2a5..7a4aa06 100755
> --- a/listvms.py
> +++ b/listvms.py
> @@ -265,6 +265,12 @@ def main():
> with connect_to_esxi_host(connection_args) as connection:
> data = {}
> for vm in list_vms(connection):
> + # skip vms with empty datastore_name
> + datastore_name, relative_vmx_path = parse_file_path(
> + vm.config.files.vmPathName
> + )
> + if not datastore_name:
While this works as a stop-gap, I think we should use the example code
here[1] to test if this is such an embedded(?) vCLS VM, and if it is
*not* such a VM, print a warning to stderr that we're skipping this VM,
so that in the future, if VMs magically disappear, we should see log
messages about this.
[1] https://knowledge.broadcom.com/external/article/370219/script-identification-for-embedded-vcls.html
> + continue
> try:
> fetch_and_update_vm_data(vm, data)
> except Exception as err:
> --
> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-08 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 15:04 Daniel Herzig
2025-04-08 9:17 ` Wolfgang Bumiller [this message]
2025-04-08 9:27 ` Daniel Herzig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rf464d4lpsr6gbpgcrv6233yq56r3fgjvxzfcv6seslqt7wk6h@kdp6jnu7sylc \
--to=w.bumiller@proxmox.com \
--cc=d.herzig@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal