all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC installer 3/6] add answer file fetch script
Date: Wed, 20 Sep 2023 11:52:41 +0200	[thread overview]
Message-ID: <p4yah5rj2vcn3sdqid33tb2usidc7ytsd4mab2yf3u47x7yx7a@qsorlps4q75k> (raw)
In-Reply-To: <20230905132832.3179097-4-a.lauterer@proxmox.com>


I think this can be part of the auto-installer itself, instead of
introducing another shell script somewhere. While yes, "do one thing and
do it well", its a rather small part and not unreasonable to move it
directly into the auto-installer.
Or have a separate Rust-written executable for this, both have their own
merits of course - just not shell :^)

If and when we add other methods of retrieving the answer file (as
illustrated in the cover letter), it makes sense to write this in a
sensible language and have a modular architecture, rather than arcane
shell scripting. (Apart from the fact that the latter might even be
nearly impossible for some things.)

On Tue, Sep 05, 2023 at 03:28:29PM +0200, Aaron Lauterer wrote:
>
> With the auto installer present, the crucial question is how we get the
> answer file. This script implements the way of a local disk/partition
> present, labelled 'proxmoxinst', lower or upper case, with the
> 'answer.toml' file in the root directory.
>
> We either want to use it directly and call it from 'unconfigured.sh' or
> see it as a first approach to showcase how it could be done.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  start_autoinstall.sh | 50 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100755 start_autoinstall.sh
>
> [..]




  reply	other threads:[~2023-09-20  9:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 13:28 [pve-devel] [RFC installer 0/6] add automated installation Aaron Lauterer
2023-09-05 13:28 ` [pve-devel] [RFC installer 1/6] low level: sys: fetch udev properties Aaron Lauterer
2023-09-05 13:28 ` [pve-devel] [RFC installer 2/6] add proxmox-auto-installer Aaron Lauterer
2023-09-21 11:16   ` Christoph Heiss
2023-09-21 11:30     ` Thomas Lamprecht
2023-09-21 11:39       ` Christoph Heiss
2023-09-05 13:28 ` [pve-devel] [RFC installer 3/6] add answer file fetch script Aaron Lauterer
2023-09-20  9:52   ` Christoph Heiss [this message]
2023-09-05 13:28 ` [pve-devel] [PATCH installer 4/6] makefile: fix handling of multiple usr_bin files Aaron Lauterer
2023-09-05 13:28 ` [pve-devel] [RFC installer 5/6] makefile: add auto installer Aaron Lauterer
2023-09-05 13:28 ` [pve-devel] [RFC docs 6/6] installation: add unattended documentation Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p4yah5rj2vcn3sdqid33tb2usidc7ytsd4mab2yf3u47x7yx7a@qsorlps4q75k \
    --to=c.heiss@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal