Re: [PATCH proxmox 2/7] notify (smtp): Introduce state module

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Mon, Mar 23, 2026 at 01:26:05PM +0100, Lukas Wagner wrote:
[...]
> > +        proxmox_sys::fs::ensure_dir_exists(parent, &context().secret_create_options(), false)
> > +            .map_err(|e| Error::ConfigSerialization(e.into()))?;
> 
> I'm getting a "bad permissions on "/etc/pve/priv/notifications" (0o700
> != 0o600)" error in the system/task logs when the token is refreshed.
> The CreateOptions provided by the context are 0o600, but I think pmxcfs
> automatically enforces the x-bit on directories, leading to 0o700 perms
> on the '/etc/pve/priv/notifications/' directory, which ultimately gives
> us this error. I think you either have to add a separate trait method
> for the directory permissions/CreateOptions, or add the x-bit to the
> existing CreateOptions yourself here at the callsite.
> 
Just looked into that, there is a `create_secret_dir` function in
`proxmox-product-config` that does exactly what we need here.
> > +
> > +        let s = serde_json::to_string_pretty(&self)
> > +            .map_err(|e| Error::ConfigSerialization(e.into()))?;
> > +
> > +        proxmox_sys::fs::replace_file(path, s.as_bytes(), context().secret_create_options(), true)
> > +            .map_err(|e| Error::ConfigSerialization(e.into()))
> > +    }
> > +
> > +    /// Set `last_refreshed`.
> > +    pub(crate) fn set_last_refreshed(mut self, last_refreshed: i64) -> Self {
> > +        self.last_refreshed = last_refreshed;
> > +        self
> > +    }
> > +
> > +    /// Set `oauth2_refresh_token`.
> > +    pub(crate) fn set_oauth2_refresh_token(mut self, oauth2_refresh_token: Option<String>) -> Self {
> > +        self.oauth2_refresh_token = oauth2_refresh_token;
> > +        self
> > +    }
> > +}
>