Re: [pbs-devel] [PATCH widget-toolkit v3 03/14] window: add panel for editing simple, built-in realms

From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH widget-toolkit v3 03/14] window: add panel for editing simple, built-in realms
Date: Thu, 22 Aug 2024 17:19:34 +0200	[thread overview]
Message-ID: <o4oijkt37keculiqzwaqqlkmizlpocdd7psnnu5z7kvwbepsip@ouucha53ndlt> (raw)
In-Reply-To: <D3JYC5NXG815.1M5LL87IQ3BYC@proxmox.com>

On Mon, Aug 19, 2024 at 04:18:54PM GMT, Hannes Laimer wrote:
> On Fri Aug 16, 2024 at 1:16 PM CEST, Christoph Heiss wrote:
> > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> > [..]
> > diff --git a/src/window/AuthEditSimple.js b/src/window/AuthEditSimple.js
> > new file mode 100644
> > index 0000000..22932c0
> > --- /dev/null
> > +++ b/src/window/AuthEditSimple.js
> > @@ -0,0 +1,41 @@
> > [..]
> > +	{
> > +	    xtype: 'proxmoxcheckbox',
> > +	    fieldLabel: gettext('Default realm'),
> > +	    name: 'default',
> > +	    value: 0,
>
> nit:
> this should include
> ```
> cbind: {
>     deleteEmpty: '{!isCreate}'
> },
> ```
> IIRC we don't send false, so it works because we PUT, but still
>

Since this panel is only used for built-in/pre-exisiting realms and no
new "simple" realms can be created, `isCreate` does not exist anyway.

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel