all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [pve-devel] [PATCH pve-firewall] tree-wide: change /var/run to /run and /var/lock to /run/lock
Date: Sun, 23 Mar 2025 00:17:16 +0900	[thread overview]
Message-ID: <mailman.93.1742657463.359.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20250322152004.1646886-1-jing@jing.rocks>

[-- Attachment #1: Type: message/rfc822, Size: 5708 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-firewall] tree-wide: change /var/run to /run and /var/lock to /run/lock
Date: Sun, 23 Mar 2025 00:17:16 +0900
Message-ID: <20250322152004.1646886-9-jing@jing.rocks>

"/var/run" and "/var/lock" are deprecated.

This is to comply with Debian Policy 9.1.4 "/run and /run/lock".
(https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock)

Signed-off-by: Jing Luo <jing@jing.rocks>
---
 src/PVE/Firewall.pm | 2 +-
 src/pvefw-logger.c  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 533f2a2..1445cbd 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -150,7 +150,7 @@ eval  {
 my $nodename = PVE::INotify::nodename();
 my $hostfw_conf_filename = "/etc/pve/nodes/$nodename/host.fw";
 
-my $pve_fw_lock_filename = "/var/lock/pvefw.lck";
+my $pve_fw_lock_filename = "/run/lock/pvefw.lck";
 
 my $default_log_level = 'nolog'; # avoid logs by default
 my $global_log_ratelimit = '--limit 1/sec';
diff --git a/src/pvefw-logger.c b/src/pvefw-logger.c
index f762505..b005046 100644
--- a/src/pvefw-logger.c
+++ b/src/pvefw-logger.c
@@ -77,8 +77,8 @@ Example:
 
 #define LOGFILE "/var/log/pve-firewall.log"
 
-#define LOCKFILE "/var/lock/pvefw-logger.lck"
-#define PIDFILE "/var/run/pvefw-logger.pid"
+#define LOCKFILE "/run/lock/pvefw-logger.lck"
+#define PIDFILE "/run/pvefw-logger.pid"
 #define LOG_CONNTRACK_FILE "/var/lib/pve-firewall/log_nf_conntrack"
 
 #define LQ_LEN 512
-- 
2.49.0




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  parent reply	other threads:[~2025-03-22 15:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250322152004.1646886-1-jing@jing.rocks>
2025-03-22 15:17 ` [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH] rust-proxmox-network-api: change /var/lock to /run/lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pmg-api] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH] rust-proxmox-backup: change " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-cluster] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-common] " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-container] tree-wide: change /var/run to /run Jing Luo via pve-devel
2025-03-22 15:17 ` Jing Luo via pve-devel [this message]
2025-03-22 15:17 ` [pve-devel] [PATCH pve-guest-common] tree-wide: change /var/lock to /run/lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-storage] " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH qemu-server] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
     [not found] ` <20250322152004.1646886-2-jing@jing.rocks>
2025-03-24  8:02   ` [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock Thomas Lamprecht
2025-03-24 11:41     ` Jing Luo via pve-devel
     [not found]     ` <d8306d3000f15b2dc4dad5f0be32db4f@jing.rocks>
2025-03-24 11:56       ` Thomas Lamprecht
2025-03-24 13:04         ` Jing Luo via pve-devel
     [not found]         ` <39e9a7cd767a4de295ab573fa71c7722@jing.rocks>
2025-03-24 13:11           ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.93.1742657463.359.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=jing@jing.rocks \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal