Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN

[Matthieu Pignolet via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 6311 bytes --]

From: Matthieu Pignolet <m@mpgn.dev>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN
Date: Tue, 11 Mar 2025 09:53:22 +0400
Message-ID: <CAB+WsT0gqCbcZCvhVSewYF-15dM05YGEx=-bhT2W1Njd_poO_g@mail.gmail.com>

According to my testing, when using the `autort` for RT auto-derivation
(from the frr patch) causes issues because it doesn't work with 32 bits
ASNs, effectively calling the fallback to restarting frr to apply the
config (which ignores the autort instruction).

Le lun. 10 mars 2025, 19:30, Shannon Sterz <s.sterz@proxmox.com> a écrit :

> On Fri Feb 28, 2025 at 3:01 PM CET, Stefan Hanreich wrote:
> > ASNs are 32-bit unsigned integers where the maximum value is
> > 4294967295.
> >
> > Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> > ---
> >  src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> > index c245ea2..78c9798 100644
> > --- a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> > +++ b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm
> > @@ -24,7 +24,7 @@ sub properties {
> >           type => 'integer',
> >           description => "autonomous system number",
> >           minimum => 0,
> > -         maximum => 4294967296
> > +         maximum => 4294967295
>
> just a small nit, it might be nicer to express that as `2**32-1` if
> that's an option.
>
> >       },
> >       peers => {
> >           description => "peers address list.",
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel