all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [pve-devel] [PATCH pve-storage] tree-wide: change /var/lock to /run/lock
Date: Sun, 23 Mar 2025 00:17:18 +0900	[thread overview]
Message-ID: <mailman.91.1742657459.359.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20250322152004.1646886-1-jing@jing.rocks>

[-- Attachment #1: Type: message/rfc822, Size: 5674 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-storage] tree-wide: change /var/lock to /run/lock
Date: Sun, 23 Mar 2025 00:17:18 +0900
Message-ID: <20250322152004.1646886-11-jing@jing.rocks>

Let's use /run/lock for lock files. Also, pve-iscsi-rescan.lock doesn't
seem to be used by any other package. "/var/lock" is deprecated.

Signed-off-by: Jing Luo <jing@jing.rocks>
---
 src/PVE/Storage/ISCSIPlugin.pm | 2 +-
 src/PVE/Storage/Plugin.pm      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm
index eb70453..49114a8 100644
--- a/src/PVE/Storage/ISCSIPlugin.pm
+++ b/src/PVE/Storage/ISCSIPlugin.pm
@@ -159,7 +159,7 @@ sub iscsi_logout {
     run_command([$ISCSIADM, '--mode', 'node', '--targetname', $target, '--logout']);
 }
 
-my $rescan_filename = "/var/run/pve-iscsi-rescan.lock";
+my $rescan_filename = "/run/lock/pve-iscsi-rescan.lock";
 
 sub iscsi_session_rescan {
     my $session_list = shift;
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 65cf43f..0c8f7d0 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -617,7 +617,7 @@ sub cluster_lock_storage {
     my $res;
     if (!$shared) {
 	my $lockid = "pve-storage-$storeid";
-	my $lockdir = "/var/lock/pve-manager";
+	my $lockdir = "/run/lock/pve-manager";
 	mkdir $lockdir;
 	$res = PVE::Tools::lock_file("$lockdir/$lockid", $timeout, $func, @param);
 	die $@ if $@;
-- 
2.49.0




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  parent reply	other threads:[~2025-03-22 15:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250322152004.1646886-1-jing@jing.rocks>
2025-03-22 15:17 ` [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH] rust-proxmox-network-api: change /var/lock to /run/lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pmg-api] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH] rust-proxmox-backup: change " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-cluster] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-common] " Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-container] tree-wide: change /var/run to /run Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-firewall] tree-wide: change /var/run to /run and /var/lock to /run/lock Jing Luo via pve-devel
2025-03-22 15:17 ` [pve-devel] [PATCH pve-guest-common] tree-wide: change " Jing Luo via pve-devel
2025-03-22 15:17 ` Jing Luo via pve-devel [this message]
2025-03-22 15:17 ` [pve-devel] [PATCH qemu-server] tree-wide: change /var/run to /run and " Jing Luo via pve-devel
     [not found] ` <20250322152004.1646886-2-jing@jing.rocks>
2025-03-24  8:02   ` [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock Thomas Lamprecht
2025-03-24 11:41     ` Jing Luo via pve-devel
     [not found]     ` <d8306d3000f15b2dc4dad5f0be32db4f@jing.rocks>
2025-03-24 11:56       ` Thomas Lamprecht
2025-03-24 13:04         ` Jing Luo via pve-devel
     [not found]         ` <39e9a7cd767a4de295ab573fa71c7722@jing.rocks>
2025-03-24 13:11           ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.91.1742657459.359.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=jing@jing.rocks \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal