Re: [pve-devel] [PATCH v4 pve-storage 3/5] storage: vdisk_free: remove external snapshots

["DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 13628 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 pve-storage 3/5] storage: vdisk_free: remove external snapshots
Date: Mon, 7 Apr 2025 11:29:34 +0000
Message-ID: <470cebc0fab87d8968a2d4462051bdebbf4b6110.camel@groupe-cyllene.com>

> + next if $snapid eq 'current';
> + next if !$snap->{volid};
> + next if !$snap->{ext};
> + my ($snap_storeid, $snap_volname) = parse_volume_id($snap-
> >{volid});
> + my (undef, undef, undef, undef, undef, $snap_isBase, $snap_format)
> =
> +     $plugin->parse_volname($volname);
> + $plugin->free_image($snap_storeid, $scfg, $snap_volname,
> $snap_isBase, $snap_format);
> +     }
> +     $plugin->free_image($storeid, $scfg, $volname, $isBase,
> $format);

>>this is the wrong place to do this, you need to handle this in the
>>cleanup worker returned by the plugin and still execute it here..
>>also you need to honor saferemove when cleaning up the snapshots

thinking about this, safemove is actually done as I'm using free_image
to delete snapshots



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel