[pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM

[pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM

[Lou Lecrivain via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 5933 bytes --]

From: Lou Lecrivain <lou.lecrivain@wdz.de>
To: pve-devel@lists.proxmox.com
Subject: SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
Date: Wed,  8 Jan 2025 13:15:22 +0100
Message-ID: <20250108121529.5813-1-lou.lecrivain@wdz.de>

Re,

Sorry for the previous thread, I got another patch mixed up and I didn't
realized. This one is the correct one. 

BR

Lou Lecrivain (7):
  ipam: nautobot support initial commit
  ipam: nautobot: implement plain prefix allocation
  ipam: nautobot: add testing for nautobot plugin
  ipam: nautobot: base plugin + enhance errors
  ipam: nautobot: add checks for prefix deletion
  ipam: nautobot: add documentation
  ipam: nautobot: systematically use namespace

 src/PVE/API2/Network/SDN/Ipams.pm             |   1 +
 src/PVE/Network/SDN/Ipams.pm                  |   3 +
 src/PVE/Network/SDN/Ipams/Makefile            |   2 +-
 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm   | 432 ++++++++++++++++++
 src/test/ipams/nautobot/expected.add_ip       |  11 +
 .../ipams/nautobot/expected.add_ip_notgateway |  11 +
 .../ipams/nautobot/expected.add_next_freeip   |  11 +
 src/test/ipams/nautobot/expected.add_subnet   |  11 +
 src/test/ipams/nautobot/expected.del_ip       |  11 +
 src/test/ipams/nautobot/expected.update_ip    |  11 +
 src/test/ipams/nautobot/ipam_config           |  24 +
 src/test/ipams/nautobot/sdn_config            |  20 +
 src/test/ipams/netbox/ipam_config             |   8 +-
 src/test/ipams/phpipam/ipam_config            |   8 +-
 14 files changed, 561 insertions(+), 3 deletions(-)
 create mode 100644 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
 create mode 100644 src/test/ipams/nautobot/expected.add_ip
 create mode 100644 src/test/ipams/nautobot/expected.add_ip_notgateway
 create mode 100644 src/test/ipams/nautobot/expected.add_next_freeip
 create mode 100644 src/test/ipams/nautobot/expected.add_subnet
 create mode 100644 src/test/ipams/nautobot/expected.del_ip
 create mode 100644 src/test/ipams/nautobot/expected.update_ip
 create mode 100644 src/test/ipams/nautobot/ipam_config
 create mode 100644 src/test/ipams/nautobot/sdn_config

-- 
2.39.5



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM

[Hannes Dürr]

Sorry it took me so long to reply.

* Please check that you stick to our style guidelines [0], I noted a few 
things inline but please check your patches again.

* All 3 patches pve-network, pve-manager, pve-docs series can be 
combined into one series


How did you test the patch, apart from the unit tests?

[0] https://pve.proxmox.com/wiki/Perl_Style_Guide

On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM

[Lou Lecrivain via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 12960 bytes --]

From: <Lou.Lecrivain@wdz.de>
To: <h.duerr@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: RE: Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
Date: Tue, 4 Mar 2025 16:34:36 +0000
Message-ID: <FR2PPF45D0062707A5331BF0DE7474EC2F385C82@FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM>

De : Hannes Dürr <h.duerr@proxmox.com>
Envoyé : mercredi 19 février 2025 17:36
À : Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc : Lecrivain, Lou (WDZ) <Lou.Lecrivain@wdz.de>
Objet : [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
 
Sorry it took me so long to reply.

* Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.

* All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series


How did you test the patch, apart from the unit tests?

[0] https://pve.proxmox.com/wiki/Perl_Style_Guide

On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re Hannes,

No problem. I myself wasn't really available either these last few weeks (sorry!)

> All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series
Thanks, will do. If I remember correctly, there was also some bug fixes related to these patches that I sent, right?
Do we agree that I keep them separated?

> How did you test the patch, apart from the unit tests?
We have a Nautobot instance in our lab (and in production). I deployed a PVE with zone type Simple, and proceeded
to test address reservation for the VMs from there. Also tested VM deletion, moving from one network to another and
all the rest of the use cases I could think of.

> Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.
Will do too! Thanks for taking the time to review it.

BR


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM

[Lou Lecrivain via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 5735 bytes --]

From: Lou Lecrivain <lou.lecrivain@wdz.de>
To: pve-devel@lists.proxmox.com
Subject: SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
Date: Wed,  8 Jan 2025 13:08:52 +0100
Message-ID: <20250108120903.5344-1-lou.lecrivain@wdz.de>

Hello all,

Following december's discussions related to the v1 of Nautobot Support
for Proxmox SDN, please find v2 of this patch herein.

I have edited the commit history to be more readable and also made the
requested changes + some improvements since the last time.

Documentation will follow.

Please let me know what you think.

Mfg
--
Lou Lecrivain 

Lou Lecrivain (7):
  ipam: nautobot support initial commit
  ipam: nautobot: implement plain prefix allocation
  ipam: nautobot: add testing for nautobot plugin
  ipam: nautobot: base plugin + enhance errors
  ipam: nautobot: add checks for prefix deletion
  ipam: nautobot: add documentation
  ipam: nautobot: systematically use namespace

 src/PVE/API2/Network/SDN/Ipams.pm             |   1 +
 src/PVE/Network/SDN/Ipams.pm                  |   3 +
 src/PVE/Network/SDN/Ipams/Makefile            |   2 +-
 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm   | 432 ++++++++++++++++++
 src/test/ipams/nautobot/expected.add_ip       |  11 +
 .../ipams/nautobot/expected.add_ip_notgateway |  11 +
 .../ipams/nautobot/expected.add_next_freeip   |  11 +
 src/test/ipams/nautobot/expected.add_subnet   |  11 +
 src/test/ipams/nautobot/expected.del_ip       |  11 +
 src/test/ipams/nautobot/expected.update_ip    |  11 +
 src/test/ipams/nautobot/ipam_config           |  24 +
 src/test/ipams/nautobot/sdn_config            |  20 +
 src/test/ipams/netbox/ipam_config             |   8 +-
 src/test/ipams/phpipam/ipam_config            |   8 +-
 14 files changed, 561 insertions(+), 3 deletions(-)
 create mode 100644 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
 create mode 100644 src/test/ipams/nautobot/expected.add_ip
 create mode 100644 src/test/ipams/nautobot/expected.add_ip_notgateway
 create mode 100644 src/test/ipams/nautobot/expected.add_next_freeip
 create mode 100644 src/test/ipams/nautobot/expected.add_subnet
 create mode 100644 src/test/ipams/nautobot/expected.del_ip
 create mode 100644 src/test/ipams/nautobot/expected.update_ip
 create mode 100644 src/test/ipams/nautobot/ipam_config
 create mode 100644 src/test/ipams/nautobot/sdn_config

-- 
2.39.5



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel