all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lou Lecrivain via pve-devel <pve-devel@lists.proxmox.com>
To: <h.duerr@proxmox.com>, <pve-devel@lists.proxmox.com>
Cc: Lou.Lecrivain@wdz.de
Subject: Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
Date: Tue, 4 Mar 2025 16:34:36 +0000	[thread overview]
Message-ID: <mailman.759.1741106301.293.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <1fb54f4a-b4d8-46f4-b90d-240d352ad76f@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 12960 bytes --]

From: <Lou.Lecrivain@wdz.de>
To: <h.duerr@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: RE: Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
Date: Tue, 4 Mar 2025 16:34:36 +0000
Message-ID: <FR2PPF45D0062707A5331BF0DE7474EC2F385C82@FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM>

De : Hannes Dürr <h.duerr@proxmox.com>
Envoyé : mercredi 19 février 2025 17:36
À : Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc : Lecrivain, Lou (WDZ) <Lou.Lecrivain@wdz.de>
Objet : [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
 
Sorry it took me so long to reply.

* Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.

* All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series


How did you test the patch, apart from the unit tests?

[0] https://pve.proxmox.com/wiki/Perl_Style_Guide

On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re Hannes,

No problem. I myself wasn't really available either these last few weeks (sorry!)

> All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series
Thanks, will do. If I remember correctly, there was also some bug fixes related to these patches that I sent, right?
Do we agree that I keep them separated?

> How did you test the patch, apart from the unit tests?
We have a Nautobot instance in our lab (and in production). I deployed a PVE with zone type Simple, and proceeded
to test address reservation for the VMs from there. Also tested VM deletion, moving from one network to another and
all the rest of the use cases I could think of.

> Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.
Will do too! Thanks for taking the time to review it.

BR


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-03-04 16:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 12:15 Lou Lecrivain via pve-devel
2025-02-19 16:36 ` Hannes Dürr
2025-03-04 16:34   ` Lou Lecrivain via pve-devel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-08 12:08 Lou Lecrivain via pve-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.759.1741106301.293.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=Lou.Lecrivain@wdz.de \
    --cc=h.duerr@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal