all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Johannes Cornelis Draaijer via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Johannes Cornelis Draaijer <jcdra1@gmail.com>
Subject: [pve-devel] [PATCH pve-network 1/1] api: sdn: fix missing types for 'pending' fields.
Date: Thu, 18 Apr 2024 18:44:27 +0200	[thread overview]
Message-ID: <mailman.704.1713458710.450.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20240418164427.13881-1-jcdra1@gmail.com>

[-- Attachment #1: Type: message/rfc822, Size: 6303 bytes --]

From: Johannes Cornelis Draaijer <jcdra1@gmail.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network 1/1] api: sdn: fix missing types for 'pending' fields.
Date: Thu, 18 Apr 2024 18:44:27 +0200
Message-ID: <20240418164427.13881-2-jcdra1@gmail.com>

Signed-off-by: Johannes Cornelis Draaijer <jcdra1@gmail.com>
---
 src/PVE/API2/Network/SDN/Controllers.pm | 2 +-
 src/PVE/API2/Network/SDN/Zones.pm       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/API2/Network/SDN/Controllers.pm b/src/PVE/API2/Network/SDN/Controllers.pm
index 0540a65..38a685d 100644
--- a/src/PVE/API2/Network/SDN/Controllers.pm
+++ b/src/PVE/API2/Network/SDN/Controllers.pm
@@ -71,7 +71,7 @@ __PACKAGE__->register_method ({
 	    properties => { controller => { type => 'string' },
 			    type => { type => 'string' },
 			    state => { type => 'string', optional => 1 },
-                            pending => { optional => 1},
+			    pending => { type => 'boolean', optional => 1 },
 	    },
 	},
 	links => [ { rel => 'child', href => "{controller}" } ],
diff --git a/src/PVE/API2/Network/SDN/Zones.pm b/src/PVE/API2/Network/SDN/Zones.pm
index 35e2f7f..2c27983 100644
--- a/src/PVE/API2/Network/SDN/Zones.pm
+++ b/src/PVE/API2/Network/SDN/Zones.pm
@@ -100,7 +100,7 @@ __PACKAGE__->register_method ({
 			    dnszone => { type => 'string', optional => 1},
 			    ipam => { type => 'string', optional => 1},
 			    dhcp => { type => 'string', optional => 1},
-			    pending => { optional => 1},
+			    pending => { type => 'boolean', optional => 1 },
 			    state => { type => 'string', optional => 1},
 			    nodes => { type => 'string', optional => 1},
 			  },
-- 
2.34.1



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

       reply	other threads:[~2024-04-18 16:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240418164427.13881-1-jcdra1@gmail.com>
2024-04-18 16:44 ` Johannes Cornelis Draaijer via pve-devel [this message]
     [not found] ` <20240418164427.13881-2-jcdra1@gmail.com>
2024-04-22 12:01   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.704.1713458710.450.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=jcdra1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal