Re: [pve-devel] [RFC storage 1/3] plugin: add method to get qemu blockdevice options for volume

["DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 12934 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [RFC storage 1/3] plugin: add method to get qemu blockdevice options for volume
Date: Fri, 23 May 2025 08:30:41 +0000
Message-ID: <175dd76aa95365010c8448bdd15eddf30aa39641.camel@groupe-cyllene.com>

>>
>>    if ($path =~ m|^/|) {
>>	# The 'file' driver only works for regular files. The check
>>below is taken from
>>	# block/file-posix.c:hdev_probe_device() in QEMU. Do not
bother >>with detecting 'host_cdrom'
>>	# devices here, those are not managed by the storage layer.
>>	my $st = File::stat::stat($path);
>>+	my $driver = (S_ISCHR($st->mode) || S_ISBLK($st->mode)) ?
'host_device' : 'file';

This is breaking my qemu-server config unit tests because the file
don't exist.

Also, for lvm volume, they are not currently activate at vm command
line generation. (but anyway, I'll need it to retrieve backing chain,
so maybe it's not a problem)


Do you think it's enough safe to rely on /dev/.. path?



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel