[pve-devel] [PATCH pve-network v2] d/control: break the circular build-dependency with pve-firewall, and more

[pve-devel] [PATCH pve-network v2] d/control: break the circular build-dependency with pve-firewall, and more

[Jing Luo via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 6919 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-network v2] d/control: break the circular build-dependency with pve-firewall, and more
Date: Sat, 23 Nov 2024 15:10:05 +0900
Message-ID: <20241123061327.1640019-1-jing@jing.rocks>

Currently pve-network has a (versioned) build-dep of pve-firewall, which has
a (versioned) runtime dependency of a newer version of libpve-network-perl,
which is not available because it has not been built. It turns out that
pve-firewall is only needed in testing, so let's only pull it in if
we don't use the "nocheck" build profile so that we can actually build
pve-network from source.

perl is a build-essential so no need to add it in build-deps.

Fixes: cbc70c81b9a2647a20903b27cabb14c1d6dc6d76
Signed-off-by: Jing Luo <jing@jing.rocks>
---
Changes since v1:
 - remove perl from build-dep because it's an essential package
 - all the perl libs are only needed in testing, so adding <!nocheck> to them
---
 debian/control | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/debian/control b/debian/control
index bb8cef9..a168c56 100644
--- a/debian/control
+++ b/debian/control
@@ -4,14 +4,13 @@ Priority: optional
 Maintainer: Proxmox Support Team <support@proxmox.com>
 Build-Depends: debhelper-compat (= 13),
                lintian,
-               libfile-slurp-perl,
-               libnet-subnet-perl,
-               libtest-mockmodule-perl,
-               perl,
-               pve-cluster (>= 8.0.10),
-               pve-firewall (>= 5.1.0~),
-               pve-doc-generator (>= 5.3-3),
-               libpve-access-control,
+               libfile-slurp-perl <!nocheck>,
+               libnet-subnet-perl <!nocheck>,
+               libtest-mockmodule-perl <!nocheck>,
+               pve-cluster (>= 8.0.10) <!nocheck>,
+               pve-firewall (>= 5.1.0~) <!nocheck>,
+               pve-doc-generator (>= 5.3-3) <!nocheck>,
+               libpve-access-control <!nocheck>,
 Standards-Version: 4.6.1
 Homepage: https://www.proxmox.com
 
-- 
2.47.0




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-network v2] d/control: break the circular build-dependency with pve-firewall, and more

[Thomas Lamprecht]

On Sat, 23 Nov 2024 15:10:05 +0900, Jing Luo via pve-devel wrote:
> Currently pve-network has a (versioned) build-dep of pve-firewall, which has
> a (versioned) runtime dependency of a newer version of libpve-network-perl,
> which is not available because it has not been built. It turns out that
> pve-firewall is only needed in testing, so let's only pull it in if
> we don't use the "nocheck" build profile so that we can actually build
> pve-network from source.
> 
> [...]

Applied, thanks!

[1/1] d/control: break the circular build-dependency with pve-firewall, and more
      commit: f79f21a1bc1959bf7fb141ca1cc2319b09495a6c


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel