[pve-devel] [PATCH pve-network] d/control: break the circular build-dependency with pve-firewall

[pve-devel] [PATCH pve-network] d/control: break the circular build-dependency with pve-firewall

[Jing Luo via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 5898 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-network] d/control: break the circular build-dependency with pve-firewall
Date: Fri, 22 Nov 2024 20:01:51 +0900
Message-ID: <20241122110243.1426459-1-jing@jing.rocks>

Currently pve-network has a (versioned) build-dep of pve-firewall, which has
a (versioned) runtime dependency of a newer version of libpve-network-perl,
which is not available because it has not been built. It turns out that
pve-firewall is only needed in testing, so let's only pull it in unless
we don't use the "nocheck" build profile so that we can actually build
pve-network from source.

Fixes: cbc70c81b9a2647a20903b27cabb14c1d6dc6d76
Signed-off-by: Jing Luo <jing@jing.rocks>
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index bb8cef9..9eeacbb 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Build-Depends: debhelper-compat (= 13),
                libtest-mockmodule-perl,
                perl,
                pve-cluster (>= 8.0.10),
-               pve-firewall (>= 5.1.0~),
+               pve-firewall (>= 5.1.0~) <!nocheck>,
                pve-doc-generator (>= 5.3-3),
                libpve-access-control,
 Standards-Version: 4.6.1
-- 
2.47.0




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel