all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Johannes Altmanninger via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Johannes Altmanninger <aclopte@gmail.com>
Subject: [pve-devel] [PATCH vncterm 2/4] Remove unused state from OSC parser
Date: Sat, 23 Aug 2025 10:17:06 +0200	[thread overview]
Message-ID: <mailman.461.1756280114.385.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20250823083010.145866-1-aclopte@gmail.com>

[-- Attachment #1: Type: message/rfc822, Size: 6494 bytes --]

From: Johannes Altmanninger <aclopte@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: Johannes Altmanninger <aclopte@gmail.com>
Subject: [PATCH vncterm 2/4] Remove unused state from OSC parser
Date: Sat, 23 Aug 2025 10:17:06 +0200
Message-ID: <20250823083010.145866-3-aclopte@gmail.com>

Signed-off-by: Johannes Altmanninger <aclopte@gmail.com>
---
 vncterm.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/vncterm.c b/vncterm.c
index fd71092..83f6bf6 100644
--- a/vncterm.c
+++ b/vncterm.c
@@ -1195,8 +1195,7 @@ enum {
     ESnonstd,
     ESpalette,
     ESidquery,
-    ESosc1,
-    ESosc2
+    ESosc,
 };
 
 static void vncterm_putchar(vncTerm *vt, unicode ch) {
@@ -1276,7 +1275,7 @@ static void vncterm_putchar(vncTerm *vt, unicode ch) {
         case '1':
         case '2':
         case '4':
-            vt->tty_state = ESosc1;
+            vt->tty_state = ESosc;
             break;
         default:
 #ifdef DEBUG
@@ -1286,17 +1285,7 @@ static void vncterm_putchar(vncTerm *vt, unicode ch) {
             break;
         }
         break;
-    case ESosc1:
-        vt->tty_state = ESnormal;
-        if (ch == ';') {
-            vt->tty_state = ESosc2;
-        } else {
-#ifdef DEBUG
-            fprintf(stderr, "got illegal OSC sequence\n");
-#endif
-        }
-        break;
-    case ESosc2:
+    case ESosc:
         if (ch == 0x9c || ch != 7) {
 #ifdef DEBUG
             fprintf(stderr, "OSC sequence\n");
-- 
2.50.1.194.g038143def7



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  parent reply	other threads:[~2025-08-27  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250823083010.145866-1-aclopte@gmail.com>
2025-08-23  8:17 ` [pve-devel] [PATCH vncterm 1/4] Remove dead code and buffer-overflow Johannes Altmanninger via pve-devel
2025-08-23  8:17 ` Johannes Altmanninger via pve-devel [this message]
2025-08-23  8:17 ` [pve-devel] [PATCH vncterm 3/4] Parse more OSC sequences Johannes Altmanninger via pve-devel
2025-08-23  8:17 ` [pve-devel] [PATCH vncterm 4/4] Also parse DCS commands Johannes Altmanninger via pve-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.461.1756280114.385.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=aclopte@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal