Re: [pve-devel] [PATCH pve-manager 0/1] feat: pass backup status to hook script on job-end/job-abort

[Constantin Herold via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 5613 bytes --]

From: Constantin Herold <proxmox8914@herold.me>
To: pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>, Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 0/1] feat: pass backup status to hook script on job-end/job-abort
Date: Sat, 27 Sep 2025 13:13:36 +0200
Message-ID: <54300259-e13c-44c8-8382-872591d7bfcc@herold.me>

So I wanted to migrate to the notification system now, but since you 
can't limit webhooks by type e.g. `backup result` it's not possible 
without another custom middleware service which would add unnecessary 
maintenance overhead and an additional point of failure.


On 24.09.25 18:48, Constantin Herold via pve-devel wrote:
>
> Re: [PATCH pve-manager 0/1] feat: pass backup status to hook script.eml
>
> Subject:
> Re: [PATCH pve-manager 0/1] feat: pass backup status to hook script on 
> job-end/job-abort
> From:
> Constantin Herold <proxmox8914@herold.me>
> Date:
> 24.09.25, 18:48
>
> To:
> Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
> CC:
> Lukas Wagner <l.wagner@proxmox.com>
>
>
> Thanks Thomas, I wasn't aware of the builtin webhook support, seems 
> like I can do what I need with the builtin `handlebars` templating 
> engine.
>
> I still think my patch would be a great addition given that scripting 
> capabilities are not limited in any way.
>
> Let me know if I need to do anything else for the Proxmox Team to 
> review it.
>
>
> On 24.09.25 11:40, Thomas Lamprecht wrote:
>> FWIW, for this the notification system might be better suited, it 
>> already
>> has support for various targets, including web hooks. That doesn't mean
>> adding info to the hook is not needed, just wanted to mention that it 
>> exist
>> and that one option might be to provide support for trigger a dedicated
>> notification for each single backup "sub-job", which would avoid the 
>> need
>> for having a custom hook if it's just to get a dedicated notification 
>> / hook
>> ASAP for each failed backup of a guest (vs. the overall result of the 
>> backups
>> of all guests).
>>
>>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel