Re: [pve-devel] [PATCH pve-storage 2/2] common: qemu_img_create: add backing_file support - DERUMIER, Alexandre via pve-devel

From: "DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"f.ebner@proxmox.com" <f.ebner@proxmox.com>
Cc: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
Subject: Re: [pve-devel] [PATCH pve-storage 2/2] common: qemu_img_create: add backing_file support
Date: Tue, 27 May 2025 08:55:18 +0000	[thread overview]
Message-ID: <mailman.42.1748336123.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <31ef5e5b-8994-49de-9634-eb59a60b78ff@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 12798 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage 2/2] common: qemu_img_create: add backing_file support
Date: Tue, 27 May 2025 08:55:18 +0000
Message-ID: <8f0a3adfa53e8b131db3594ee1006a84fcd8522c.camel@groupe-cyllene.com>

>>I'd prefer having a second dedicated function
>>qemu_img_create_qcow2_with_backing() rather than an interface where
>>some
>>parameters need to be undef depending on how you want to use it. It
>>also
>>doesn't require a format parameter, because we only allow it for
>>qcow2.

ok !

>  
> - my $cmd = ['/usr/bin/qemu-img', 'create', '-b',
> "../$basevmid/$basename",
> -    '-F', $format, '-f', 'qcow2', $path];

>>...but the old command was using "-F $format -f qcow2"!

ah yes, sorry, thanks !

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel