From: Constantin Herold via pve-devel <pve-devel@lists.proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Cc: Constantin Herold <proxmox8914@herold.me>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 0/1] feat: pass backup status to hook script on job-end/job-abort
Date: Wed, 24 Sep 2025 18:48:30 +0200 [thread overview]
Message-ID: <mailman.379.1758732519.390.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <0c613244-24ea-4538-83b6-bc25e71a045d@proxmox.com>
[-- Attachment #1: Type: message/rfc822, Size: 4453 bytes --]
From: Constantin Herold <proxmox8914@herold.me>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Cc: Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [PATCH pve-manager 0/1] feat: pass backup status to hook script on job-end/job-abort
Date: Wed, 24 Sep 2025 18:48:30 +0200
Message-ID: <a2731689-205a-4f6b-b8db-9d08a8a2a29b@herold.me>
Thanks Thomas, I wasn't aware of the builtin webhook support, seems like
I can do what I need with the builtin `handlebars` templating engine.
I still think my patch would be a great addition given that scripting
capabilities are not limited in any way.
Let me know if I need to do anything else for the Proxmox Team to review it.
On 24.09.25 11:40, Thomas Lamprecht wrote:
> FWIW, for this the notification system might be better suited, it already
> has support for various targets, including web hooks. That doesn't mean
> adding info to the hook is not needed, just wanted to mention that it exist
> and that one option might be to provide support for trigger a dedicated
> notification for each single backup "sub-job", which would avoid the need
> for having a custom hook if it's just to get a dedicated notification / hook
> ASAP for each failed backup of a guest (vs. the overall result of the backups
> of all guests).
>
>
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-09-24 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250923174007.84121-1-proxmox8914@herold.me>
2025-09-23 17:40 ` [pve-devel] [PATCH pve-manager 1/1] " Constantin Herold via pve-devel
2025-09-24 9:40 ` [pve-devel] [PATCH pve-manager 0/1] " Thomas Lamprecht
2025-09-24 16:48 ` Constantin Herold via pve-devel [this message]
2025-09-23 17:40 Constantin Herold via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.379.1758732519.390.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=proxmox8914@herold.me \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.