all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [pve-devel] [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean`
Date: Fri, 27 Sep 2024 22:45:53 +0900	[thread overview]
Message-ID: <mailman.152.1727769306.332.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20240927134831.2655916-1-jing@jing.rocks>

[-- Attachment #1: Type: message/rfc822, Size: 5175 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean`
Date: Fri, 27 Sep 2024 22:45:53 +0900
Message-ID: <20240927134831.2655916-2-jing@jing.rocks>

There is no difference in the source or binary packge running with or
without `--no-pre-clean`. On the other hand, dpkg-buildpackge complains
loudly when `--no-pre-clean` is specified, so let's remove it.

Signed-off-by: Jing Luo <jing@jing.rocks>
---
 common/pkg/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/pkg/Makefile b/common/pkg/Makefile
index 1e5cf1d..cbefdf7 100644
--- a/common/pkg/Makefile
+++ b/common/pkg/Makefile
@@ -51,7 +51,7 @@ $(BUILDDIR): debian PVE Proxmox Makefile
 .PHONY: deb
 deb: $(DEB)
 $(DEB): $(BUILDDIR)
-	cd $(BUILDDIR); dpkg-buildpackage -b -us -uc --no-pre-clean
+	cd $(BUILDDIR); dpkg-buildpackage -b -us -uc
 	lintian $(DEB)
 
 .PHONY: dsc
-- 
2.46.2




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

       reply	other threads:[~2024-10-01  7:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240927134831.2655916-1-jing@jing.rocks>
2024-09-27 13:45 ` Jing Luo via pve-devel [this message]
2024-11-11 10:41 ` [pve-devel] applied: [PATCH proxmox-perl-rs] common: d/control: change binary package architecture from `any` to `all` Thomas Lamprecht
     [not found] ` <20240927134831.2655916-2-jing@jing.rocks>
2024-11-11 10:42   ` [pve-devel] applied: [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.152.1727769306.332.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=jing@jing.rocks \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal