From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
Cc: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage] lvm: use blkdiscard instead cstream to saferemove drive
Date: Thu, 14 Aug 2025 14:05:51 +0200 [thread overview]
Message-ID: <kkrxayfuo4vhyzqswghw3evwll4b37okjulkxlmwq2ztanlyd6@5td4beeats46> (raw)
In-Reply-To: <9d5353263ee0aa3ee67d8d331f674f8a00044b1e.camel@groupe-cyllene.com>
On Thu, Aug 14, 2025 at 10:07:59AM +0000, DERUMIER, Alexandre wrote:
> > + saferemove_discard => {
> > + description => "Wipe with discard instead zeroing.",
> > + type => 'boolean',
>
> >>Not sure we need this (not sure when this is actually useful), but
> >>it's
> >>cheap enough to have around. Should add a `default => 0` for
> >>documentation purposes, though.
>
> Some storage allow overprovisioning. (create a lun bigger than the real
> storage size), it can be interesting to discard instead zeroing (to
> free space on storage side).
> as snapshots currently use lvm volume with same size than the main
> volume, it can be interesting to have overprovisioning.
But this does not guarantee that the data is actually erased/zeroed, in
which case I'd just disable the thing altogether (but then again I use
`issue_discards` in lvm.conf to cause `lvremove` to discard the whole
thing... ;-)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-14 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 9:24 Alexandre Derumier via pve-devel
2025-08-14 9:37 ` Wolfgang Bumiller
2025-08-14 10:07 ` DERUMIER, Alexandre via pve-devel
[not found] ` <9d5353263ee0aa3ee67d8d331f674f8a00044b1e.camel@groupe-cyllene.com>
2025-08-14 12:05 ` Wolfgang Bumiller [this message]
2025-08-14 13:11 ` DERUMIER, Alexandre via pve-devel
2025-08-15 5:10 ` DERUMIER, Alexandre via pve-devel
2025-08-15 5:47 ` DERUMIER, Alexandre via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kkrxayfuo4vhyzqswghw3evwll4b37okjulkxlmwq2ztanlyd6@5td4beeats46 \
--to=w.bumiller@proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.