From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 0/2] ui: fw: allow selecting network interface for rules using combogrid
Date: Tue, 26 Sep 2023 09:37:44 +0200 [thread overview]
Message-ID: <jbfj5abpnevmg56jbwjciruy6hojk5gy54datrkxlim73nw7db@f4cbmnqwtbi4> (raw)
In-Reply-To: <20230511094620.667892-1-c.heiss@proxmox.com>
Ping.
While it does not apply cleanly on current master anymore, I'd like to
collect some general feedback on the approach before rebasing +
resending w/o any actual changes.
On Thu, May 11, 2023 at 11:46:18AM +0200, Christoph Heiss wrote:
>
> For nodes, VMs and CTs we can show the user a list of available network
> interfaces (as that information is available) when creating a new
> firewall rule, much like it is already done in similar places.
> Adds a lot of convenience when creating new firewall rules if they are
> interface-specific, as you get a nice summary of the available ones and
> can simply select it instead of typing it out each time.
>
> The first patch refactors the `BridgeSelector` component a bit into a
> new `NetworkInterfaceSelector`, is essence allowing it be used for any
> type of network interfaces. No functional changes there.
>
> The second patch contains the actual implementation, using the
> `NetworkInterfaceSelector` from above for nodes and introducing a new
> component (which is mostly based of the former) for VMs/CTs.
> For datacenter rules, the simple textbox is kept.
>
> pve-manager:
>
> Christoph Heiss (2):
> ui: fw: generalize `BridgeSelector` into network interface selector
> ui: fw: allow selecting network interface for rules using combogrid
>
> www/manager6/Makefile | 3 +-
> www/manager6/form/BridgeSelector.js | 71 -----------------
> www/manager6/form/NetworkInterfaceSelector.js | 79 +++++++++++++++++++
> .../form/VMNetworkInterfaceSelector.js | 79 +++++++++++++++++++
> www/manager6/grid/FirewallRules.js | 37 ++++++++-
> www/manager6/lxc/Config.js | 1 +
> www/manager6/lxc/Network.js | 3 +-
> www/manager6/qemu/Config.js | 1 +
> www/manager6/qemu/NetworkEdit.js | 3 +-
> 9 files changed, 199 insertions(+), 78 deletions(-)
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
prev parent reply other threads:[~2023-09-26 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 9:46 Christoph Heiss
2023-05-11 9:46 ` [pve-devel] [PATCH manager 1/2] ui: fw: generalize `BridgeSelector` into network interface selector Christoph Heiss
2023-05-11 9:46 ` [pve-devel] [PATCH manager 2/2] ui: fw: allow selecting network interface for rules using combogrid Christoph Heiss
2023-11-17 15:15 ` Wolfgang Bumiller
2023-09-26 7:37 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jbfj5abpnevmg56jbwjciruy6hojk5gy54datrkxlim73nw7db@f4cbmnqwtbi4 \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.