Re: [PATCH proxmox-backup v6 0/8] fixes #6195: add support for moving groups and namespaces

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Tue, Mar 31, 2026 at 02:34:01PM +0200, Hannes Laimer wrote:
> Add support for moving backup groups and entire namespace subtrees to
> a different location within the same datastore.
> 
> Groups are moved with exclusive per-group and per-snapshot locking.
> For S3, objects are copied to the target prefix before deleting the
> source. Namespace moves process groups individually, deferring and
> retrying lock conflicts once, so partially failed moves can be
> completed with move_group.
> 
> 
> v6, thanks @Fabian and @Dominik!:
>  - drop ns locks, lock everything directly, like we do for delete. only
>    difference, we dont do partial group moves, reason being that we
>    cant move single snapshots, so cleanup would not really be possible
>  - ui: disable purne for empty groups
>  - ui: dont render verification status for empty groups
> 
> v5, thanks @Chris!:
>  - lock dir instead of `.ns-lock` file
>  - explicitly drop ns lock guards in specific order
>  - improve cleanup of partially failed s3 moves, we now create the local
>    empty dir+owner file before we start copying s3 objects, if any of
>    the s3 ops fail, the dir stays behind and can be deleted through the
>    UI(which also triggers a prefix cleanup on the s3 storage)
>  - update parameters for `DataStore::lookup_datastore()`
>  - ui: re-ordered actions, `move` now next to `verify`
>  - ui: add move to right-click context menu
>  - ui: show empty groups in the UI
>  - add cli commands for both ns and group moves
>  - add 2s ns lock timeout for worker tasks
> 
> *note*: given the UI change to show empty groups it could make sense to
> not auto-delete a group if the last snapshot is deleted. For this series
> though that is not relevant since we just need empty groups to be
> deletable through the UI for partially failed s3 moves
>
[...]
Hey!

I played around with this, I think the UI looks nice and the feature
works well.  

Here's what I tested (on both normal and S3-backed datastores, both 
in the UI and with the CLI commands):

I can move namespaces/groups to other namespaces and to the root
namespace without issues. I was also able to rename a namespace
by moving it (like `mv`). I was not able to move a namespace/group 
if it would result in an ID collision in the target namespace, nor 
could I move a namespace to itself. I also could not move a group 
during a backup.

I did not find any issues while testing and the error messages
are helpful.

I answered {7,8}/8 with some UX nits, but in general I think
this looks nice, so consider this series:

Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>