From: Christoph Heiss <c.heiss@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 15/30] auto-installer: add fetch answer binary
Date: Tue, 2 Apr 2024 14:03:38 +0200 [thread overview]
Message-ID: <g65do4kxi4yejrzlwdc73pb4qwcfrjp2j6z6zbfwkeidxrhj3x@kiipkl2xw3lz> (raw)
In-Reply-To: <20240328135028.504520-16-a.lauterer@proxmox.com>
Two typos ;) And some small nits
On Thu, Mar 28, 2024 at 02:50:13PM +0100, Aaron Lauterer wrote:
[..]
> diff --git a/proxmox-auto-installer/src/bin/proxmox-fetch-answer.rs b/proxmox-auto-installer/src/bin/proxmox-fetch-answer.rs
> new file mode 100644
> index 0000000..9e89a3c
> --- /dev/null
> +++ b/proxmox-auto-installer/src/bin/proxmox-fetch-answer.rs
[..]
> +fn main() -> ExitCode {
> + if let Err(err) = init_log() {
> + panic!("could not initilize logging: {err}");
^^^^^^^^^
typo
And for consistency sake, capitalize the first word here too as done
everywhere else?
> + }
> +
> + info!("Fetching answer file");
> + let answer = match fetch_answer() {
> + Ok(answer) => answer,
> + Err(err) => {
> + error!("Aborting: {}", err);
> + return ExitCode::FAILURE;
> + }
> + };
> +
> + let mut child = match Command::new("proxmox-auto-installer")
> + .stdout(Stdio::inherit())
> + .stdin(Stdio::piped())
> + .stderr(Stdio::null())
> + .spawn()
> + {
> + Ok(child) => child,
> + Err(err) => panic!("Failed to start automatic installation: {}", err),
Very much a nit; but above always inline format-strings (i.e. "{err}")
are used, from here on out mostly explicit parameters. Maybe unify them
and use the former consistenly where possible?
E.g. below in `utils.rs` are some more instances
> + };
> +
> + let mut stdin = child.stdin.take().expect("Failed to open stdin");
> + std::thread::spawn(move || {
> + stdin
> + .write_all(answer.as_bytes())
> + .expect("Failed to write to stdin");
> + });
[..]
> diff --git a/proxmox-auto-installer/src/fetch_plugins/utils.rs b/proxmox-auto-installer/src/fetch_plugins/utils.rs
> new file mode 100644
> index 0000000..82cd3e0
> --- /dev/null
> +++ b/proxmox-auto-installer/src/fetch_plugins/utils.rs
> @@ -0,0 +1,90 @@
> +use anyhow::{bail, Result};
> +use log::{info, warn};
> +use std::{
> + fs::create_dir_all,
> + path::{Path, PathBuf},
> + process::Command,
> +};
> +
> +/// Searches for upper and lower case existence of the partlabel in the search_path
> +///
> +/// # Arguemnts
> +/// * `partlabel_lower` - Partition Label in lower case
> +/// * `search_path` - Path where to search for the partiiton label
> +/// search_path: String
Stray last line?
> +pub fn scan_partlabels(partlabel_lower: &str, search_path: &str) -> Result<PathBuf> {
> + let partlabel = partlabel_lower.to_uppercase();
> + let path = Path::new(search_path).join(partlabel.clone());
^^^^^^^^^^^^^^^^^
Can be `&partlabel`
> + match path.try_exists() {
> + Ok(true) => {
> + info!("Found partition with label '{}'", partlabel);
> + return Ok(path);
> + }
> + Ok(false) => info!("Did not detect partition with label '{}'", partlabel),
> + Err(err) => info!("Encountered issue, accessing '{}': {}", path.display(), err),
> + }
> +
> + let partlabel = partlabel_lower.to_lowercase();
Since you explicitly convert it to lowercase anyway here, I'd say name
`partlabel_lower` does not make much sense (anymore)?
> + let path = Path::new(search_path).join(partlabel.clone());
^^^^^^^^^^^^^^^^^
Same here
> + match path.try_exists() {
> + Ok(true) => {
> + info!("Found partition with label '{}'", partlabel);
> + return Ok(path);
> + }
> + Ok(false) => info!("Did not detect partition with label '{}'", partlabel),
> + Err(err) => info!("Encountered issue, accessing '{}': {}", path.display(), err),
> + }
> + bail!(
> + "Could not detect upper or lower case labels for '{}'",
> + partlabel_lower
> + );
> +}
> +
[..]
> +/// Tries to unmount the specified path. Will warn on errors, but not fail.
> +///
> +/// # Arguemnts
> +/// * `target_path` - path to unmount
> +pub fn umount_part(target_path: &str) -> Result<()> {
> + info!("Unmounting partitiona at {target_path}");
^^^^^^^^^^
typo
> + match Command::new("umount").arg(target_path).output() {
> + Ok(output) => {
> + if output.status.success() {
> + Ok(())
> + } else {
> + warn!("Error unmounting: {}", String::from_utf8(output.stderr)?);
> + Ok(())
> + }
> + }
> + Err(err) => {
> + warn!("Error unmounting: {}", err);
> + Ok(())
> + }
> + }
> +}
next prev parent reply other threads:[~2024-04-02 12:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 13:49 [pve-devel] [PATCH v3 00/30] add automated/unattended installation Aaron Lauterer
2024-03-28 13:49 ` [pve-devel] [PATCH v3 01/30] tui: common: move InstallConfig struct to common crate Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 02/30] common: make InstallZfsOption members public Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 03/30] common: tui: use BTreeMap for predictable ordering Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 04/30] common: utils: add deserializer for CidrAddress Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 05/30] common: options: add Deserialize trait Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 06/30] low-level: add dump-udev command Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 07/30] add auto-installer crate Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 08/30] auto-installer: add dependencies Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 09/30] auto-installer: add answer file definition Aaron Lauterer
2024-03-29 11:43 ` Christoph Heiss
2024-03-29 12:37 ` Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 10/30] auto-installer: add struct to hold udev info Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 11/30] auto-installer: add utils Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 12/30] auto-installer: add simple logging Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 13/30] auto-installer: add tests for answer file parsing Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 14/30] auto-installer: add auto-installer binary Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 15/30] auto-installer: add fetch answer binary Aaron Lauterer
2024-04-02 12:03 ` Christoph Heiss [this message]
2024-03-28 13:50 ` [pve-devel] [PATCH v3 16/30] unconfigured: add proxauto as option to start auto installer Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 17/30] auto-installer: use glob crate for pattern matching Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 18/30] auto-installer: utils: make get_udev_index functions public Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 19/30] auto-installer: add proxmox-autoinst-helper tool Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 20/30] auto-installer: fetch: add gathering of system identifiers and restructure code Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 21/30] auto-installer: helper: add subcommand to view indentifiers Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 22/30] auto-installer: fetch: add http post utility module Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 23/30] auto-installer: fetch: add http plugin to fetch answer Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 24/30] control: update build depends for auto installer Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 25/30] auto installer: factor out fetch-answer and autoinst-helper Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 26/30] low-level: write low level config to /tmp Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 27/30] common: add deserializer for FsType Aaron Lauterer
2024-03-29 12:20 ` Christoph Heiss
2024-03-29 12:38 ` Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 28/30] common: skip target_hd when deserializing InstallConfig Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 29/30] common: add Display trait to ProxmoxProduct Aaron Lauterer
2024-03-28 13:50 ` [pve-devel] [PATCH v3 30/30] add proxmox-chroot utility Aaron Lauterer
2024-03-28 13:53 ` [pve-devel] [PATCH v3 00/30] add automated/unattended installation Aaron Lauterer
2024-04-02 14:43 ` Christoph Heiss
2024-04-02 14:55 ` Aaron Lauterer
2024-04-03 8:19 ` Christoph Heiss
2024-04-03 8:47 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g65do4kxi4yejrzlwdc73pb4qwcfrjp2j6z6zbfwkeidxrhj3x@kiipkl2xw3lz \
--to=c.heiss@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.