From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied-series: [PATCH installer 0/5] use hostname from DHCP lease if available
Date: Tue, 24 Oct 2023 09:45:01 +0200 [thread overview]
Message-ID: <ft5v3hfgdgmxrkfdwi2kistzhr7sclt2ffh2gpniwt3qmjw64i@hvf33viizktz> (raw)
In-Reply-To: <df0ef220-117d-4080-a082-10bd0a8f52a7@proxmox.com>
On Fri, Oct 20, 2023 at 05:21:41PM +0200, Thomas Lamprecht wrote:
>
> Am 20/10/2023 um 11:46 schrieb Christoph Heiss:
> > DHCP servers can set option 12 ("host-name") for client leases [0],
> > telling them about their hostname. It's very much non-invasive and falls
> > back to the default values as done currently.
> >
> > This came up while talking to Aaron, which he noticed (esp. during
> > trainings) that this would be a very useful feature too have.
> >
> > I have tested this with the "host-name" entry set and unset, as well as
> > any combinations of that with the domain name being set or unset.
> >
> > [0] https://datatracker.ietf.org/doc/html/rfc2132#section-3.14
> > [..]
>
> applied series, squashed in a trivial fix to fix the tests though, you
> probably based of an older git state where the Interface struct doesn't
> have the "state" member yet, thanks!
Yeah, exactly. Sorry about that - thanks for fixing it up & applying!
prev parent reply other threads:[~2023-10-24 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:46 [pve-devel] " Christoph Heiss
2023-10-20 9:46 ` [pve-devel] [PATCH installer 1/5] net: move hostname/fqdn regexes into common code Christoph Heiss
2023-10-20 9:46 ` [pve-devel] [PATCH installer 2/5] run env: retrieve and store hostname from DHCP lease if available Christoph Heiss
2023-10-20 9:46 ` [pve-devel] [PATCH installer 3/5] proxinstall: use hostname from run env " Christoph Heiss
2023-10-20 9:46 ` [pve-devel] [PATCH installer 4/5] tui: " Christoph Heiss
2023-10-20 9:46 ` [pve-devel] [PATCH installer 5/5] tui: add some tests for `NetworkInfo` -> `NetworkOptions` conversion Christoph Heiss
2023-10-20 15:21 ` [pve-devel] applied-series: [PATCH installer 0/5] use hostname from DHCP lease if available Thomas Lamprecht
2023-10-24 7:45 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ft5v3hfgdgmxrkfdwi2kistzhr7sclt2ffh2gpniwt3qmjw64i@hvf33viizktz \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal