From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 installer] fix #4430: add UTC timezone as option to installer
Date: Thu, 16 Mar 2023 12:33:07 +0100 [thread overview]
Message-ID: <fffa3f14-e767-6e28-bf07-bd0c1a175825@proxmox.com> (raw)
In-Reply-To: <20230316100136.97432-1-c.heiss@proxmox.com>
Am 16/03/2023 um 11:01 schrieb Christoph Heiss:
> Adds 'Etc/UTC' as option to the timezone selection, regardless of what
> country is selected.
>
> The 'Etc/' prefix needs to be stripped for the installation, as this
> value is written to /etc/timezone. PVE/PMG/PBS already use 'UTC' without
> the prefix, so avoid regressing them.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Would it be sensible to fix up the timezone change component in the UI
> so that it uses 'Etc/UTC' (which is the canonical timezone name for UTC)
> as well? As separate patch in the future, of course.
IMO no, the Etc/ is mostly a detail of the IANA zone db format/data, but not
really used when talking about UTC or setting the timezone to it.
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-March/056202.html
>
> proxinstall | 4 ++++
> 1 file changed, 4 insertions(+)
>
>
applied, with a followup that drops the "Etc/" prefix (IMO would mostly confuse
some of our users at best), thanks!
prev parent reply other threads:[~2023-03-16 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 10:01 [pve-devel] " Christoph Heiss
2023-03-16 11:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffa3f14-e767-6e28-bf07-bd0c1a175825@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.