From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-flutter-frontend] node overview: power menu: reorder/reword confirm buttons
Date: Wed, 17 Apr 2024 15:44:54 +0200 [thread overview]
Message-ID: <ff421bc2-19cc-4253-ab01-541567f7e718@proxmox.com> (raw)
In-Reply-To: <20240417085302.1754758-1-d.csapak@proxmox.com>
Am 17/04/2024 um 10:53 schrieb Dominik Csapak:
> move the confirm action to the right as mentioned in the material spec[0]
> also rewords the buttons to 'cancel' and 'shutdown/reboot'
> for that to work properly slightly rename the confirm message
>
> 0: https://m3.material.io/components/dialogs/guidelines#befd7f4d-1029-4957-b1b5-da13fc0bbf3c
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> replaces v3 of my previous patch since v2 was applied:
> https://lists.proxmox.com/pipermail/pve-devel/2024-April/063106.html
>
> lib/widgets/pve_node_power_settings_widget.dart | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>
applied, with rewording the commit message a bit to make it easier
to read (flow wise) and adding a Suggested-by trailer to give Folke
credit for his review/suggestion – thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-17 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:53 [pve-devel] " Dominik Csapak
2024-04-17 13:44 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff421bc2-19cc-4253-ab01-541567f7e718@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.